net/ftp.rb: add NullSocket#closed? to fix closing not yet opened connection
I've opened a PR for this issue on GitHub: https://github.com/ruby/ruby/pull/1232
An instance of
NullSocket is stored in a
@sock variable of a new
Net::FTP, it also has a
#close method (that obviously does nothing), but it is never called, because a wrapping
Net::FTP#close checks that
@sock and not @sock.closed? which crashes with
FTPConnectionError because there is no method
NullSocket. This PR adds it and a test to verify that it works.
Below is the way to reproduce the error in the IRB. As you can see it's quite confusing, you'd expect
#closed? not to raise an error, but return
>> ftp = Net::FTP.new => #<Net::FTP:0x007f90c38075e0 @mon_owner=nil, @mon_count=0, @mon_mutex=#<Thread::Mutex:0x007f90c3807590>, @binary=true, @passive=true, @debug_mode=false, @resume=false, @sock=#<Net::FTP::NullSocket:0x007f90c3807568>, @logged_in=false, @open_timeout=nil, @read_timeout=60> >> ftp.close Net::FTPConnectionError: not connected from /usr/local/var/rbenv/versions/2.3.0/lib/ruby/2.3.0/net/ftp.rb:1277:in `method_missing' from /usr/local/var/rbenv/versions/2.3.0/lib/ruby/2.3.0/net/ftp.rb:1168:in `close' from (irb):6 from /usr/local/var/rbenv/versions/2.3.0/bin/irb:11:in `<main>' >> ftp.closed? Net::FTPConnectionError: not connected from /usr/local/var/rbenv/versions/2.3.0/lib/ruby/2.3.0/net/ftp.rb:1277:in `method_missing' from /usr/local/var/rbenv/versions/2.3.0/lib/ruby/2.3.0/net/ftp.rb:1184:in `closed?' from (irb):7 from /usr/local/var/rbenv/versions/2.3.0/bin/irb:11:in `<main>'