Project

General

Profile

Misc #12439

[PATCH cleanup] process.c (disable_child_handler_fork_child): simplify

Added by normalperson (Eric Wong) about 3 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
[ruby-core:75781]

Description

process.c (disable_child_handler_fork_child): simplify

signal(2) is portable for SIG_DFL and SIG_IGN, so we do not
need the extra code for sigaction(2).

Also, execve will reset all signal handlers to default
anyways, so there is little sense in preserving old
signal handler besides SIG_IGN.

Hopefully this makes the code easier-to-understand and
maintain.

Comments? Will commit in a week or two if no response.
Thanks.


Files

Associated revisions

Revision 80a0c0f8
Added by normal almost 3 years ago

process.c (disable_child_handler_fork_child): simplify

signal(2) is portable for SIG_DFL and SIG_IGN, so we do not
need the extra code for sigaction(2).

Also, execve will reset all signal handlers to default
anyways, so there is little sense in preserving old
signal handler besides SIG_IGN.

Hopefully this makes the code easier-to-understand and
maintain.

  • process.c (disable_child_handler_fork_child): simplify [ruby-core:75781] [Misc #12439]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55566 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 55566
Added by normalperson (Eric Wong) almost 3 years ago

process.c (disable_child_handler_fork_child): simplify

signal(2) is portable for SIG_DFL and SIG_IGN, so we do not
need the extra code for sigaction(2).

Also, execve will reset all signal handlers to default
anyways, so there is little sense in preserving old
signal handler besides SIG_IGN.

Hopefully this makes the code easier-to-understand and
maintain.

  • process.c (disable_child_handler_fork_child): simplify [ruby-core:75781] [Misc #12439]

Revision 55566
Added by normal almost 3 years ago

process.c (disable_child_handler_fork_child): simplify

signal(2) is portable for SIG_DFL and SIG_IGN, so we do not
need the extra code for sigaction(2).

Also, execve will reset all signal handlers to default
anyways, so there is little sense in preserving old
signal handler besides SIG_IGN.

Hopefully this makes the code easier-to-understand and
maintain.

  • process.c (disable_child_handler_fork_child): simplify [ruby-core:75781] [Misc #12439]

Revision 55566
Added by normal almost 3 years ago

process.c (disable_child_handler_fork_child): simplify

signal(2) is portable for SIG_DFL and SIG_IGN, so we do not
need the extra code for sigaction(2).

Also, execve will reset all signal handlers to default
anyways, so there is little sense in preserving old
signal handler besides SIG_IGN.

Hopefully this makes the code easier-to-understand and
maintain.

  • process.c (disable_child_handler_fork_child): simplify [ruby-core:75781] [Misc #12439]

Revision 55566
Added by normal almost 3 years ago

process.c (disable_child_handler_fork_child): simplify

signal(2) is portable for SIG_DFL and SIG_IGN, so we do not
need the extra code for sigaction(2).

Also, execve will reset all signal handlers to default
anyways, so there is little sense in preserving old
signal handler besides SIG_IGN.

Hopefully this makes the code easier-to-understand and
maintain.

  • process.c (disable_child_handler_fork_child): simplify [ruby-core:75781] [Misc #12439]

History

#1

Updated by shyouhei (Shyouhei Urabe) about 2 years ago

  • Status changed from Open to Assigned

Updated by akr (Akira Tanaka) over 1 year ago

  • Status changed from Assigned to Closed

It seems already committed.

Also available in: Atom PDF