Project

General

Profile

Actions

Bug #12464

closed

URI.regexp should not include comma at the end of string if followed by whitespace

Added by alpracka (Nikos Timiopulos) about 6 years ago. Updated almost 6 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Target version:
-
ruby -v:
ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-darwin15]
[ruby-core:75864]

Description

Hello,

URI.regexp should not include comma at the end of string if followed by whitespace in my opinion.

USE CASES:

  1. test string: "http://domain.com, " - URI.regexp matches: "http://domain.com" (without comma)
  2. test string: "http://domain.com/?params=21,22,23, " - URI.regexp matches: "http://domain.com/?params=21,22,23," (with comma)

The point is some users are typing URLs with comma behind so than links are broken.

Updated by naruse (Yui NARUSE) about 6 years ago

  • Status changed from Open to Closed

It is the matter of URL spec.
https://url.spec.whatwg.org/

If the spec is changed as you say, we'll follow it.

Updated by usa (Usaku NAKAMURA) almost 6 years ago

  • Status changed from Closed to Rejected
Actions

Also available in: Atom PDF