Bug #12530: Module Refinements

• Status: Rejected
• Assignee: shugo (Shugo Maeda)
• Target version: -
• ruby -v: ruby 2.3.1p112
• Backport: 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN

[noxxxname (Pavlo Vavruk)]

Hi guys, I noticed strange situation with module refinements.

There is difference with using methods which you refine.

User.new.users will return ["a", "b", "c", "d%"]
User.new.users_not_work will fail with error "undefined method `apply_user_name!' for "a":String"

 module Punctuations
    refine String do
      COMMON_PUNCTUATION = %w(. , ! ?)

      def apply_user_name!
        chop! if COMMON_PUNCTUATION.include?(last)
      end
    end
  end

  class User
    using Punctuations

    def names
      ["a", "b.", "c!", "d%"]
    end

    def users
      names.each { |word| word.apply_user_name! }
    end

    def users_not_work
      names.each(&:apply_user_name!)
    end
 end

[noxxxname (Pavlo Vavruk)]

• ruby -v changed from 2.3.1 to ruby 2.3.1p112

[shugo (Shugo Maeda)]

• Status changed from Open to Rejected
• Assignee set to shugo (Shugo Maeda)

This is not a bug, but an expected behavior.
However, changing this behavior is being discussed in #12079.

[shugo (Shugo Maeda)]

• Is duplicate of Feature #12079: Loosening the condition for refinement added