Bug #12952: Incompatibility of a method signature between `Float#round` and `BigDecimal#round`

• Status: Closed
• Assignee: mrkn (Kenta Murata)
• Target version: -
• ruby -v: ruby 2.4.0preview3 (2016-11-07 trunk 56661) [x86_64-darwin14]
• Backport: 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN

[yui-knk (Kaneko Yuichiro)]

We can not call BigDecimal("0.5").round(half: :up).
This prevents us from duck typing Float objects and BigDecimal objects.

irb(main):001:0> require "bigdecimal"
=> true
irb(main):002:0> 0.5.round(half: :up)
=> 1
irb(main):003:0> BigDecimal("0.5").round(half: :up)
TypeError: no implicit conversion of Hash into Integer
	from (irb):3:in `round'
	from (irb):3
	from /Users/kaneko/.rbenv/versions/2.4.0-preview3/bin/irb:11:in `<main>'
irb(main):004:0> BigDecimal.ver
=> "1.1.0"

[mrkn (Kenta Murata)]

• Status changed from Open to Assigned
• Assignee set to mrkn (Kenta Murata)

I'm working on it in https://github.com/ruby/bigdecimal/pull/14

[mrkn (Kenta Murata)]

• Related to Feature #12953: (Float, Integer, Rational)#round(half: :down) added

[mrkn (Kenta Murata)]

I've fixed this in bigdecimal version 1.3.0.pre, which has already been imported in trunk.

[mrkn (Kenta Murata)]

• Status changed from Assigned to Closed