Feature #12971: (Refactoring) Remove `defined?` checks from observer.rb

• Status: Closed
• Assignee: -
• Target version: -

[itsNikolay (Nikolay Ponomarev)]

Remove defined? checks from observer.rb

• Contains less code
• Easier to understand Observable logic
• No performance downgrade

[itsNikolay (Nikolay Ponomarev)]

Github Pull Request: https://github.com/ruby/ruby/pull/1489

[itsNikolay (Nikolay Ponomarev)]

can be closed also =\

[nobu (Nobuyoshi Nakada)]

You have to define the instance method, not setting instance variables on Observable module.
For example:

  module Initializer
    def initialize(*)
      @observer_peers ||= {}
      @observer_state ||= false
      super
    end
  end

  def self.included(mod)
    mod.prepend(Initializer)
    super
  end

[nobu (Nobuyoshi Nakada)]

• Description updated (diff)

[jeremyevans0 (Jeremy Evans)]

• Status changed from Open to Closed