Project

General

Profile

Actions
Copy link

Bug #12990

closed

unicode_case_mapping_tests

Bug #12990: unicode_case_mapping_tests

Added by nobu (Nobuyoshi Nakada) almost 10 years ago. Updated almost 10 years ago.

Status:
Closed
Assignee:
duerst (Martin Dürst)
Target version:
-
ruby -v:
56907
Backport:
2.1: DONTNEED, 2.2: DONTNEED, 2.3: DONTNEED
[ruby-core:78410]

Description

I found that tests generated by TestComprehensiveCaseFold.unicode_case_mapping_tests compares target with same target, which should be always true usually.
I suspect this is unintentional, tried comparison target with result,

diff --git a/test/ruby/enc/test_case_comprehensive.rb b/test/ruby/enc/test_case_comprehensive.rb
index 13639f3..cfff9b8 100644
--- a/test/ruby/enc/test_case_comprehensive.rb
+++ b/test/ruby/enc/test_case_comprehensive.rb
@@ -149,7 +149,7 @@
           source = code.encode(encoding) * 5
           target = "#{test.first_data[code]}#{test.follow_data[code]*4}".encode(encoding)
           result = source.__send__(test.method_name, *test.attributes)
-          assert_equal target, target,
+          assert_equal target, result,
             proc{"from #{code*5} (#{source.dump}) expected #{target.dump} but was #{result.dump}"}
         end
       end

and got 30 failures.

Is this intentional?

Actions
Copy link

Also available in: PDF Atom