Project

General

Profile

Bug #13011

Make `trace_running` an integer flag again

Added by deivid (David Rodríguez) about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
ruby -v:
ruby 2.4.0dev (2016-12-06 trunk 56997) [x86_64-linux]
[ruby-core:78514]

Description

After https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/55038, byebug's tests started to segfault. See, for example, https://travis-ci.org/deivid-rodriguez/byebug/jobs/130941967.

I investigated a bit and it seems to me that the trace_running flag was not suitable to be converted to a bit field (at least not without extra changes), since reverting the changes to that flag fixes the problem.

Find the patch I used attached.

Thanks!


Files


Related issues

Has duplicate Ruby master - Bug #12945: Use-after-free in vm_trace.cClosedActions

Associated revisions

Revision d71b5394
Added by nobu (Nobuyoshi Nakada) about 3 years ago

Make trace_running an integer flag again

  • vm_core.h (rb_vm_struct): trace_running should be a counter but not a bit flag. [ruby-core:78514] [Bug #13011]

Author: David Rodríguez deivid.rodriguez@gmail.com

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@57002 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 57002
Added by nobu (Nobuyoshi Nakada) about 3 years ago

Make trace_running an integer flag again

  • vm_core.h (rb_vm_struct): trace_running should be a counter but not a bit flag. [ruby-core:78514] [Bug #13011]

Author: David Rodríguez deivid.rodriguez@gmail.com

Revision 57002
Added by nobu (Nobuyoshi Nakada) about 3 years ago

Make trace_running an integer flag again

  • vm_core.h (rb_vm_struct): trace_running should be a counter but not a bit flag. [ruby-core:78514] [Bug #13011]

Author: David Rodríguez deivid.rodriguez@gmail.com

Revision 57002
Added by nobu (Nobuyoshi Nakada) about 3 years ago

Make trace_running an integer flag again

  • vm_core.h (rb_vm_struct): trace_running should be a counter but not a bit flag. [ruby-core:78514] [Bug #13011]

Author: David Rodríguez deivid.rodriguez@gmail.com

Revision 57002
Added by nobu (Nobuyoshi Nakada) about 3 years ago

Make trace_running an integer flag again

  • vm_core.h (rb_vm_struct): trace_running should be a counter but not a bit flag. [ruby-core:78514] [Bug #13011]

Author: David Rodríguez deivid.rodriguez@gmail.com

History

#1

Updated by nobu (Nobuyoshi Nakada) about 3 years ago

  • Status changed from Open to Closed

Applied in changeset r57002.


Make trace_running an integer flag again

  • vm_core.h (rb_vm_struct): trace_running should be a counter but not a bit flag. [ruby-core:78514] [Bug #13011]

Author: David Rodríguez deivid.rodriguez@gmail.com

Updated by deivid (David Rodríguez) about 3 years ago

Wow, that was fast, thank you Nobu! :)

#3

Updated by nobu (Nobuyoshi Nakada) almost 3 years ago

  • Has duplicate Bug #12945: Use-after-free in vm_trace.c added

Also available in: Atom PDF