Project

General

Profile

Actions

Bug #13184

closed

unused parameter in ruby.h - native ruby extension compilation failure on ruby 2.4

Added by apolcyn (alex polcyn) over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-core:79399]

Description

platform and version:
x86_64-darwin14
2.4.0

When compiling a ruby c-extension on the above ruby platform and version, the compilation fails with an error:
In file included from ../../../../src/ruby/ext/grpc/rb_byte_buffer.c:34:
/usr/local/rvm/rubies/ruby-2.4.0/include/ruby-2.4.0/ruby/ruby.h:2339:8: error: unused parameter 'varc' [-Werror,-Wunused-parameter]
int varc, VALUE *vars[])

To reproduce:

With ruby on the above platform and version:

git clone https://github.com/grpc/grpc.git
git checkout 26623b3d77ae78e66f66b (tip of master at current time of posting)
cd grpc && git submodule update --init
gem install bundle
BUNDLE_SPECIFIC_PLATFORM=true bundle install # bundle install crashes on this platform, BUNDLE_SPECIFIC_PLATFORM followed as a work around, followed suggestion in: https://github.com/bundler/bundler/issues/3692
rake compile

Compilation should failure with the error above.

An example failure log is posted.

We're using rake-compiler gem to compile the grpc-ruby gem native extension.
The extconf.rb Makefile generator is in grpc/src/ruby/ext/grpc/extconf.rb -- this file currently sets -Werror as a compilation option. We're planning to remove it for the time being as work around but would like to put it back in.


Files

log (76.2 KB) log apolcyn (alex polcyn), 02/03/2017 12:43 AM
Actions #1

Updated by nobu (Nobuyoshi Nakada) over 5 years ago

  • Status changed from Open to Closed

Applied in changeset r57520.


ruby.h: unused parameter

  • include/ruby/ruby.h (rb_scan_args_set): remove unused parameter
    for more pedantic extension libraries.
    [ruby-core:79399] [Feature #13184]

Updated by naruse (Yui NARUSE) over 5 years ago

  • Backport set to 2.2: DONTNEED, 2.3: DONTNEED, 2.4: REQUIRED
  • Tracker changed from Feature to Bug

Updated by naruse (Yui NARUSE) over 5 years ago

  • Backport changed from 2.2: DONTNEED, 2.3: DONTNEED, 2.4: REQUIRED to 2.2: DONTNEED, 2.3: DONTNEED, 2.4: DONE

ruby_2_4 r57896 merged revision(s) 57520.

Actions

Also available in: Atom PDF