Feature #13828
closedWin32ole extension should support licensed COM servers
Description
Current implementation doesn't support licensed COM servers. I've added keyword argument :license
which when used switches to using IClassFactory2::CreateInstanceLic
instead of CoCreateInstance
.
Default behaviour was not touched in any way, so it doesn't break anything. And the license version works in my testing.
Files
Updated by nobu (Nobuyoshi Nakada) almost 7 years ago
- Status changed from Open to Assigned
- Assignee set to suke (Masaki Suketa)
- adjust indents
- use
rb_scan_args
andrb_get_kwargs
- don't mix a declaration with code
Updated by graywolf (Gray Wolf) almost 7 years ago
- File licensed_com.patch licensed_com.patch added
nobu (Nobuyoshi Nakada) wrote:
- adjust indents
Fixed
- use
rb_scan_args
andrb_get_kwargs
Do you mean via ":" in rb_scan_args
? I tried that at first actually, but had some troubles getting it work (here is what happened: https://gist.github.com/anonymous/714752bfb3744ba80f556d10f06f8c04 ). Could you point me to some documentation (or at least source code using it) about using "*:" together in rb_scan_args?
- don't mix a declaration with code
Sorry, missed the C90 requirement, fixed.
Updated by graywolf (Gray Wolf) almost 7 years ago
- File licensed_com.patch licensed_com.patch added
nobu (Nobuyoshi Nakada) wrote:
- use
rb_scan_args
andrb_get_kwargs
bug reported in #13830 was resolved, so now I can use rb_scan_args
and rb_get_kwargs
. Updated version attached.
Updated by suke (Masaki Suketa) almost 7 years ago
- Status changed from Assigned to Closed
Applied in changeset trunk|r59665.
- ext/win32ole/win32ole.c (fole_initialize): support licensed COM server. Thanks to Gray Wolf. [Feature :#13828]
Updated by graywolf (Gray Wolf) almost 7 years ago
Looking at trunk|r59665, there a typo keyward_ids
, dunno if it's worth fixing.