Bug #13845: thread_win32.c: set thread name breaking mswin builds on appveyor and at rubyci

• Status: Closed
• Assignee: -
• Target version: -
• ruby -v: trunk since 59660
• Backport: 2.2: UNKNOWN, 2.3: UNKNOWN, 2.4: UNKNOWN

[MSP-Greg (Greg L)]

The commit svn 59660 thread_win32.c: set thread name is breaking builds on both appveyor and at rubyci.

It appears to be using a function that is only supported on Windows 10, version 1607 (desktop apps only) and Windows Server 2016 (desktop apps only). See SetThreadDescription.

If there's logic to determine OS version, it appears to not be working correctly. If ruby core has decided that trunk use should be restricted to these OS versions, please let everyone know.

Otherwise, when someone has time, please correct this issue. This is also causing failures on MinGW builds. Again, thanks for everyone's work.

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Closed

Applied in changeset trunk|r59678.

---

win32.c: fix function pointer

• win32/win32.c (rb_w32_set_thread_description): fix the condition
  if the API function pointer is found.
  [ruby-core:82494] [Bug #13845]