Actions
Bug #13957
closedreadline が SHARABLE_MIDDLE_SUBSTRING=1 を考慮していない
Status:
Closed
Assignee:
-
Target version:
-
ruby -v:
ruby 2.5.0dev (2017-09-29 trunk 60062) [x86_64-linux]
Backport:
Description
SHARABLE_MIDDLE_SUBSTRING=1 でコンパイルしたRubyで、Readline.insert_text の文字列が正しく扱われません。
% ruby -rreadline -e 'p Readline.insert_text(("a"*100)[0,24]).line_buffer'
"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
次のパッチで直ると思います。
diff --git a/ext/readline/readline.c b/ext/readline/readline.c
index 253798f9e6..deebc282f5 100644
--- a/ext/readline/readline.c
+++ b/ext/readline/readline.c
@@ -93,6 +93,7 @@ static char **readline_attempted_completion_function(const char *text,
#define OutputStringValue(str) do {\
SafeStringValue(str);\
+ StringValueCStr(str);\
(str) = rb_str_conv_enc((str), rb_enc_get(str), rb_locale_encoding());\
} while (0)\
パッチ適用後
% ruby -rreadline -e 'p Readline.insert_text(("a"*100)[0,24]).line_buffer'
"aaaaaaaaaaaaaaaaaaaaaaaa"
Updated by nobu (Nobuyoshi Nakada) over 6 years ago
- Status changed from Open to Closed
- Backport changed from 2.3: UNKNOWN, 2.4: UNKNOWN to 2.3: REQUIRED, 2.4: REQUIRED
Updated by nagachika (Tomoyuki Chikanaga) over 6 years ago
- Backport changed from 2.3: REQUIRED, 2.4: REQUIRED to 2.3: REQUIRED, 2.4: DONE
ruby_2_4 r61456 merged revision(s) 60071.
Updated by usa (Usaku NAKAMURA) about 6 years ago
- Backport changed from 2.3: REQUIRED, 2.4: DONE to 2.3: DONE, 2.4: DONE
ruby_2_3 r62140 merged revision(s) 60071.
Actions
Like0
Like0Like0Like0