Project

General

Profile

Bug #14345

http_proxy setting should respect both parent domain and subdomain

Added by harsimranmaan (Harsimran Singh Maan) 6 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-core:84789]

Description

When a ruby app is run in an environment where an http proxy is configured, it is not possible to provide separate settings for both a domain and it's subdomain for outbound http calls. This coupling assumes that both should follow the same http_proxy settings but in practice, this is a common occurrence the parent domain and the subdomains are be hosted on different network.

https://github.com/ruby/ruby/pull/1748 addresses this issues.

Also note that other programming language like go respect different proxy settings for parent domain and its subdomains. https://github.com/golang/go/blob/master/src/net/http/proxy_test.go#L37

Associated revisions

Revision d50ecb63
Added by naruse (Yui NARUSE) 2 months ago

http_proxy setting should respect both parent domain and subdomain

URI::Generic: Respect no_proxy for both parent domain and
subdomains It is now possible to add just the subdomains for proxy bypass. In
a setting where the main domain needs to go through proxy while the
subdomains don't, it is now possible to just add the subdomains to the
no_proxy list.
The assumption that subdomains and the parent domain should
behave the same wrt no_proxy has been removed.

eg: Adding .example.com in no_proxy would allow example.com
to go through the proxy.

From: Harsimran Singh Maan maan.harry@gmail.com
fix https://github.com/ruby/ruby/pull/1748
[Bug #14345]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63452 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 63452
Added by naruse (Yui NARUSE) 2 months ago

http_proxy setting should respect both parent domain and subdomain

URI::Generic: Respect no_proxy for both parent domain and
subdomains It is now possible to add just the subdomains for proxy bypass. In
a setting where the main domain needs to go through proxy while the
subdomains don't, it is now possible to just add the subdomains to the
no_proxy list.
The assumption that subdomains and the parent domain should
behave the same wrt no_proxy has been removed.

eg: Adding .example.com in no_proxy would allow example.com
to go through the proxy.

From: Harsimran Singh Maan maan.harry@gmail.com
fix https://github.com/ruby/ruby/pull/1748
[Bug #14345]

History

#2 [ruby-core:86277] Updated by shevegen (Robert A. Heiler) 4 months ago

I think this will be discussed at the next ruby developer meeting
in April 2018 so stay tuned for updates to it (less than a month
to go for the next developer meeting).

See here:

https://bugs.ruby-lang.org/projects/ruby/wiki/DevelopersMeeting20180419Japan

#3 Updated by naruse (Yui NARUSE) 2 months ago

  • Status changed from Open to Closed

Applied in changeset trunk|r63452.


http_proxy setting should respect both parent domain and subdomain

URI::Generic: Respect no_proxy for both parent domain and
subdomains It is now possible to add just the subdomains for proxy bypass. In
a setting where the main domain needs to go through proxy while the
subdomains don't, it is now possible to just add the subdomains to the
no_proxy list.
The assumption that subdomains and the parent domain should
behave the same wrt no_proxy has been removed.

eg: Adding .example.com in no_proxy would allow example.com
to go through the proxy.

From: Harsimran Singh Maan maan.harry@gmail.com
fix https://github.com/ruby/ruby/pull/1748
[Bug #14345]

Also available in: Atom PDF