Project

General

Profile

Bug #14494

[PATCH] tool/m4/ruby_replace_type.m4 use AC_CHECK_TYPES for HAVE_* macros

Added by normalperson (Eric Wong) over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Target version:
-
[ruby-core:85634]

Description

tool/m4/ruby_replace_type.m4: use AC_CHECK_TYPES for HAVE_* macros

Without this, HAVE_CLOCKID_T goes undefined and I can't
USE_MONOTONIC_COND in thread_pthread.c :<


Files

Associated revisions

Revision e691d4d7
Added by normal about 1 year ago

tool/m4/ruby_replace_type.m4: use AC_CHECK_TYPES for HAVE_* macros

AC_CHECK_TYPE (no "S") does not define HAVE_* macros for types,
so use AC_CHECK_TYPES (with "S") instead. Without this,
HAVE_CLOCKID_T goes undefined and I can't USE_MONOTONIC_COND in
thread_pthread.c :<

Fixes: r62446 (git 673ae0e3c9cefd693ef82f19a6761e147fc6de93)
("configure.ac: check clockid_t with necessary headers")

  • tool/m4/ruby_replace_type.m4: use AC_CHECK_TYPES for HAVE_* macros [ruby-core:85659] [Bug #14494]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62495 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 62495
Added by normalperson (Eric Wong) about 1 year ago

tool/m4/ruby_replace_type.m4: use AC_CHECK_TYPES for HAVE_* macros

AC_CHECK_TYPE (no "S") does not define HAVE_* macros for types,
so use AC_CHECK_TYPES (with "S") instead. Without this,
HAVE_CLOCKID_T goes undefined and I can't USE_MONOTONIC_COND in
thread_pthread.c :<

Fixes: r62446 (git 673ae0e3c9cefd693ef82f19a6761e147fc6de93)
("configure.ac: check clockid_t with necessary headers")

  • tool/m4/ruby_replace_type.m4: use AC_CHECK_TYPES for HAVE_* macros [ruby-core:85659] [Bug #14494]

Revision 62495
Added by normal about 1 year ago

tool/m4/ruby_replace_type.m4: use AC_CHECK_TYPES for HAVE_* macros

AC_CHECK_TYPE (no "S") does not define HAVE_* macros for types,
so use AC_CHECK_TYPES (with "S") instead. Without this,
HAVE_CLOCKID_T goes undefined and I can't USE_MONOTONIC_COND in
thread_pthread.c :<

Fixes: r62446 (git 673ae0e3c9cefd693ef82f19a6761e147fc6de93)
("configure.ac: check clockid_t with necessary headers")

  • tool/m4/ruby_replace_type.m4: use AC_CHECK_TYPES for HAVE_* macros [ruby-core:85659] [Bug #14494]

History

Updated by normalperson (Eric Wong) over 1 year ago

normalperson@yhbt.net wrote:

Without this, HAVE_CLOCKID_T goes undefined and I can't
USE_MONOTONIC_COND in thread_pthread.c :<

On a side note, I also realized we have no use for realtime
condvars, only monotonic ones....

Updated by normalperson (Eric Wong) over 1 year ago

Eric Wong wrote:

On a side note, I also realized we have no use for realtime
condvars, only monotonic ones....

Yep, and drop more code, too:
https://80x24.org/spew/20180219090629.17506-1-e@80x24.org/raw

(I also reused the condattr since pthread_cond_init does not modify it)

Updated by nobu (Nobuyoshi Nakada) about 1 year ago

Indeed, it was a mistake.
Do you think HAVE_ macros should be defined for all RUBY_REPLACE_TYPE?

Updated by normalperson (Eric Wong) about 1 year ago

nobu@ruby-lang.org wrote:

Indeed, it was a mistake.
Do you think HAVE_ macros should be defined for all RUBY_REPLACE_TYPE?

Probably, but I was wondering what your opinion is.
We only use RUBY_REPLACE_TYPES for common t types, so I don't
think there's any conflicts with function names for HAVE
.

Updated by nobu (Nobuyoshi Nakada) about 1 year ago

I have no particular opinion on it, probably it'd be convenient.

#6

Updated by Anonymous about 1 year ago

  • Status changed from Open to Closed

Applied in changeset trunk|r62495.


tool/m4/ruby_replace_type.m4: use AC_CHECK_TYPES for HAVE_* macros

AC_CHECK_TYPE (no "S") does not define HAVE_* macros for types,
so use AC_CHECK_TYPES (with "S") instead. Without this,
HAVE_CLOCKID_T goes undefined and I can't USE_MONOTONIC_COND in
thread_pthread.c :<

Fixes: r62446 (git 673ae0e3c9cefd693ef82f19a6761e147fc6de93)
("configure.ac: check clockid_t with necessary headers")

  • tool/m4/ruby_replace_type.m4: use AC_CHECK_TYPES for HAVE_* macros [ruby-core:85659] [Bug #14494]

Also available in: Atom PDF