Bug #14562: Do not warn for assignment in conditionals inside ()

• Status: Closed
• Assignee: -
• Target version: -
• ruby -v: ruby 2.6.0dev (2018-03-01 trunk 62617) [x86_64-darwin16]
• Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN

[matsuda (Akira Matsuda)]

Ruby warns against this code, which is very helpful.

% ruby -we 'if a=1; p a; end'
-e:1: warning: found = in conditional, should be ==
1

So there's a commonly known practice. In order to express that we're intentionally assigning (not missing one more = sign), we usually add parens around the assignment.

But in fact, Ruby still warns...

% ruby -we 'if (a=1); p a; end'
-e:1: warning: found = in conditional, should be ==
1

Can this behavior changed not to warn when parenthesized?

[nobu (Nobuyoshi Nakada)]

Just remove if.
It is the warning for assignment of a literal, which is not "conditional".

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Closed

Applied in changeset trunk|r62620.

---

parse.y: refine assign_in_cond warning

• parse.y (assign_in_cond): refine a warning message for
  assignment of a literal in conditinal expression.
  [ruby-core:85872] [Bug #14562]

[nobu (Nobuyoshi Nakada)]

• Has duplicate Feature #15848: Silence warning when conditional assignments are wrapped in parentheses added