Bug #14617: rdoc crashes when expression contains embedded comment: no implicit conversion of nil into String (TypeError)

• Status: Closed
• Priority: Normal
• Assignee: hsbt (Hiroshi SHIBATA)
• Target version: -
• ruby -v: ruby 2.5.0p0 (2017-12-25 revision 61468) [x86_64-linux]
• Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: REQUIRED

[vo.x (Vit Ondruch)]

RDoc might fail when comment is inside code, such as:

def meth
  variable # comment
    .chain
end

I was made aware of this issue via this bug 1 report, but it has been already reported 2 and fixed 3 upstream. Would be nice if this is fixed in RDoc shipped in Ruby.

[vo.x (Vit Ondruch)]

• ruby -v set to ruby 2.5.0p0 (2017-12-25 revision 61468) [x86_64-linux]

$ rdoc -v
6.0.1

[aycabta (aycabta .)]

This bug is fixed. RDoc 6.0.2 was released two days ago. Please use it.

[aycabta (aycabta .)]

I was made aware of this issue via this bug [1] report, but it has been already reported [2] and fixed [3] upstream. Would be nice if this is fixed in RDoc shipped in Ruby.

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1556732
[2]: https://github.com/ruby/rdoc/issues/585
[3]: https://github.com/ruby/rdoc/pull/586

Sorry, I understand this issue's intention.

This issue should be assigned to @hsbt.

[hsbt (Hiroshi SHIBATA)]

• Assignee set to hsbt (Hiroshi SHIBATA)
• Status changed from Open to Assigned

[hsbt (Hiroshi SHIBATA)]

• Status changed from Assigned to Closed

Merged RDoc 6.0.3 at r62924

[vo.x (Vit Ondruch)]

• Backport changed from 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN to 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: REQUIRED

[vo.x (Vit Ondruch)]

Thx. I hope this gets backported into next stable update.