Project

General

Profile

Actions

Misc #14720

closed

[PATCH] cont.c: cleanup needless cast

Added by normalperson (Eric Wong) almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
[ruby-core:86741]

Description

It seems like leftover development step from r59557
("refactoring Fiber status").

I will make fiber_status use BITFIELD macro in a future
commit.

  • cont.c (struct rb_fiber_struct): drop const from fiber_status
    (fiber_status_set): remove cast

Seems trivial. const seems overkill after at this time. Will commit in a few
days if no objection (also have auto-fiber/green-thread stuff which touches
this area of code)


Files

0001-cont.c-cleanup-needless-cast (0 Bytes) 0001-cont.c-cleanup-needless-cast normalperson (Eric Wong), 04/28/2018 03:49 AM
0001-cont.c-cleanup-needless-cast.patch (1.44 KB) 0001-cont.c-cleanup-needless-cast.patch normalperson (Eric Wong), 04/28/2018 05:05 AM

Updated by ko1 (Koichi Sasada) almost 6 years ago

0001-cont.c-cleanup-needless-cast (0 Bytes)

it seems redmine system error.

Updated by normalperson (Eric Wong) almost 6 years ago

wrote:

0001-cont.c-cleanup-needless-cast (0 Bytes)

Reattached. Also posted to :
https://80x24.org/spew/20180428050438.16831-1-e@80x24.org/raw

Updated by ko1 (Koichi Sasada) almost 6 years ago

Thank you. No problem.

Actions #5

Updated by normalperson (Eric Wong) almost 6 years ago

  • Status changed from Open to Closed

Applied in changeset trunk|r63315.


cont.c: cleanup needless cast

It seems like leftover development step from r59557
("refactoring Fiber status").

I will make fiber_status use BITFIELD macro in a future
commit.

  • cont.c (struct rb_fiber_struct): drop const from fiber_status
    (fiber_status_set): remove cast
    [ruby-core:86788] [Misc #14720]
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0