Bug #14828: syn 63583 fix for windows

• Status: Closed
• Assignee: -
• Target version: -
• ruby -v: ruby 2.6.0dev (2018-06-05 trunk 63572) [x64-mingw32]
• Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN

[MSP-Greg (Greg L)]

@normalperson (Eric Wong)

svn 63583 seems to have broken the mswin build, I have the same issue locally with MinGW. The methods set_winsize_setup and set_winsize_teardown are defined base on whether PTY is defined. It is not on windows.

The test test_set_winsize_console is run regardless of whether PTY exsists, and hence the 'NameError: undefined local variable or method' message.

Attached patch is one way to fix the issue.

Thanks, Greg

[normalperson (Eric Wong)]

• Status changed from Open to Closed

Applied in changeset trunk|r63585.

---

test/io/console/test_io_console.rb: fix for systems where PTY is not defined

[ruby-core:87420] [Bug #14828]
Thanks-to: MSP-Greg (Greg L)

[normalperson (Eric Wong)]

[e-mail] wrote:

https://bugs.ruby-lang.org/issues/14828

Thanks for the report. I moved the methods to be defined
globally in all cases, instead: r63585