Project

General

Profile

Misc #14854

mjit (2.6.0-preview2) enabled on cygwin

Added by fd0 (Daisuke Fujimura) 4 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
[ruby-dev:50579]

Description

cygwin で 2.6.0-preview2 の mjit をとりあえずで動かせるようにしてみました。
(コンパイルできるだけのレベル)

patch & log
https://gist.github.com/fd00/80b25c33ffef0651b7214d19e722848f

cygwin だと必ず false になるという都合で
pthread_attr_setscope(&attr, PTHREAD_SCOPE_SYSTEM) == 0 を
コメントアウトしてますが、この関数が必須なら cygwin で mjit は
動かさない方が良いということだと思います。

Associated revisions

Revision ea0cede5
Added by k0kubun (Takashi Kokubun) 4 months ago

mjit.c: initial cygwin support

thread_pthread.c: Drop pthread_attr_setscope usage. It seems that,
at least on Linux and macOS, PTHREAD_SCOPE_PROCESS is not supported
and thus PTHREAD_SCOPE_SYSTEM should be used by default.

Let's just stop calling this until we find some platform that needs
pthread_attr_setscope(&attr, PTHREAD_SCOPE_SYSTEM).

[Misc #14854]

From: fd0 (Daisuke Fujimura)

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63730 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 63730
Added by k0kubun (Takashi Kokubun) 4 months ago

mjit.c: initial cygwin support

thread_pthread.c: Drop pthread_attr_setscope usage. It seems that,
at least on Linux and macOS, PTHREAD_SCOPE_PROCESS is not supported
and thus PTHREAD_SCOPE_SYSTEM should be used by default.

Let's just stop calling this until we find some platform that needs
pthread_attr_setscope(&attr, PTHREAD_SCOPE_SYSTEM).

[Misc #14854]

From: fd0 (Daisuke Fujimura)

History

#1 [ruby-dev:50581] Updated by hsbt (Hiroshi SHIBATA) 4 months ago

  • Assignee set to k0kubun (Takashi Kokubun)
  • Status changed from Open to Assigned

#2 Updated by k0kubun (Takashi Kokubun) 4 months ago

  • Status changed from Assigned to Closed

Applied in changeset trunk|r63730.


mjit.c: initial cygwin support

thread_pthread.c: Drop pthread_attr_setscope usage. It seems that,
at least on Linux and macOS, PTHREAD_SCOPE_PROCESS is not supported
and thus PTHREAD_SCOPE_SYSTEM should be used by default.

Let's just stop calling this until we find some platform that needs
pthread_attr_setscope(&attr, PTHREAD_SCOPE_SYSTEM).

[Misc #14854]

From: fd0 (Daisuke Fujimura)

Also available in: Atom PDF