Project

General

Profile

Actions

Bug #14870

closed

Both TracePoint's :call and :c_call filters seem to skip a lot of builtin methods

Added by yarmiganosca (Chris Hoffman) about 3 years ago. Updated 27 days ago.

Status:
Closed
Priority:
Normal
Target version:
-
[ruby-core:87638]

Description

It looks like a lot of builtin methods (Array#<< and Integer#+, for example) aren't hooked when using the :call or :c_call filters for TracePoint.

➜ irb
 :001 > [RUBY_VERSION, RUBY_PATCHLEVEL]
 => ["2.5.1", 57] 
 :002 > TracePoint.new(:call, :c_call) { |tp| puts tp.method_id if tp.method_id == :<< }.enable { [] << 4 }
 => [4] 
 :003 > TracePoint.new(:call, :c_call) { |tp| puts tp.method_id if tp.method_id == :concat }.enable { [].concat([4]) }
concat
 => [4]
 :004 > TracePoint.new(:call, :c_call) { |tp| puts tp.method_id if tp.method_id == :+ }.enable { 1 + 1 }
 => 2 
 :005 > TracePoint.new(:call, :c_call) { |tp| puts tp.method_id if tp.method_id == :+ }.enable { 1.0 + 1.0 }
 => 2.0

I can understand if TracePoint being able to hook every method call against every object would be prohibitive from a performance perspective, but the TracePoint documentation currently doesn't indicate that it ignores entire classes of methods, so either the implementation should support every method call (maybe through other event types, if necessary) or the documentation should be clear about what TracePoint filters will and won't hook into.

Updated by marcandre (Marc-Andre Lafortune) about 3 years ago

  • Assignee set to nobu (Nobuyoshi Nakada)

Mmm, that's indeed a bug that should be fixed imo.

This indeed happens because of optimizations for basic operators (in insns.def):

TracePoint.new(:call, :c_call) { |tp| puts tp.method_id }.enable { 42 % 2 } # => No printing
# These don't go through the optimizations of insns.def:
TracePoint.new(:call, :c_call) { |tp| puts tp.method_id }.enable { 42.send(:%, 2) } # => %
TracePoint.new(:call, :c_call) { |tp| puts tp.method_id }.enable { 42.modulo(2) } # => modulo

I'm confident that Nobu will find the most efficient way to fix this.

Actions #2

Updated by jeremyevans (Jeremy Evans) 27 days ago

  • Status changed from Open to Closed

Applied in changeset git|48c8df9e0eb295af06d593ce37ce1933c0ee1d90.


Allow tracing of optimized methods

This updates the trace instructions to directly dispatch to
opt_send_without_block. So this should cause no slowdown in
non-trace mode.

To enable the tracing of the optimized methods, RUBY_EVENT_C_CALL
and RUBY_EVENT_C_RETURN are added as events to the specialized
instructions.

Fixes [Bug #14870]

Co-authored-by: Takashi Kokubun takashikkbn@gmail.com

Actions

Also available in: Atom PDF