Project

General

Profile

Bug #14966

2.5 branch - Appveyor failures - backport missed line

Added by MSP-Greg (Greg L) 3 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
ruby -v:
Current Ruby 2.5 branch
[ruby-core:88302]

Description

A while ago, hsbt (Hiroshi SHIBATA) committed r62990, and the following line was in test\test_tmpdir.rb:

TRAVERSAL_PATH.delete!(':') if /mswin|mingw/ =~ RUBY_PLATFORM

When it was backported to 2.5 (r62971), the line was omitted. I believe it needs to be inserted at line 61. That should allow Appveyor ruby_2_5 branch to pass...

Thanks, Greg

1939.patch (719 Bytes) 1939.patch hsbt (Hiroshi SHIBATA), 08/20/2018 10:23 PM

Associated revisions

Revision bf0dcd5b
Added by nagachika (Tomoyuki Chikanaga) about 2 months ago

test/test_tmpdir.rb(TRAVERSAL_PATH): re-apply r62990 partially. [Backport #14966]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@64621 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 64621
Added by nagachika (Tomoyuki Chikanaga) about 2 months ago

test/test_tmpdir.rb(TRAVERSAL_PATH): re-apply r62990 partially. [Backport #14966]

History

#2 [ruby-core:88580] Updated by MSP-Greg (Greg L) 2 months ago

Please see GitHub PR 1939, which passed.

I guess a look at ruby_2_4 is next, as it's also failing...

#3 Updated by hsbt (Hiroshi SHIBATA) 2 months ago

  • Backport changed from 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN to 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: REQUIRED
  • Status changed from Open to Closed
  • File 1939.patch 1939.patch added

#4 [ruby-core:88820] Updated by nagachika (Tomoyuki Chikanaga) about 2 months ago

  • Backport changed from 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: REQUIRED to 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: DONE

Hello Greg,

Thank you very much for your notice.
I have applied your patch at r64621 in ruby_2_5 branch.

Also available in: Atom PDF