Bug #15020: [PATCH] Add 'guards' for mswin, mingw, update test_readline.rb

• Status: Closed
• Assignee: -
• Target version: -
• Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN

[MSP-Greg (Greg L)]

When the mingw build was added, test_readline.rb failed. One test fails on mingw, several tests error due to the windows issue with "can't close a file with an existing ref on it".

See GH PR #1941. Both the PR and a ruby-loco build using the same patch passed.

This adds mswin? & mingw? methods to MiniTest::Unit::Guard, fixup readline test for mingw

The patch is at https://patch-diff.githubusercontent.com/raw/ruby/ruby/pull/1941.patch or see attached.

Also reverts some of r64365 and all of r64369.

Thanks, Greg

[MSP-Greg (Greg L)]

@k0kubun (Takashi Kokubun),

I forgot one patch that I have on ext/readline/extconf.rb, at ruby-loco/patches/ext-readline-extconf.rb.patch

All three of the header variables exist on MinGW and appear 'correctly' in the readline mkmf.log. I have all the extension build files locally, and also save them on builds that fail (maybe I should save them for all ruby-loco builds?).

I don't know how much work should go into readline on MinGW. Since I've used PowerShell and normal windows editors for years, the keyboard shortcuts in readline drive me crazy, so I've never used it.

Traditionally, MinGW builds use rb-readline (poor substitute), and I include it in the ruby-loco 7z files. It does not pass as many tests as the readline extension, and is missing some methods (along some HISTORY methods).

Feel free to close, & thanks, Greg

[k0kubun (Takashi Kokubun)]

• Status changed from Open to Closed

Applied in changeset trunk|r64526.

---

ext/readline/extconf.rb: try using more readline APIs

on MinGW.

[Bug #15020]

From: MSP-Greg [e-mail]