Bug #15203: test-all WEBrick - fixes needed for Azure Pipelines - three asserts, line endings

• Status: Closed
• Assignee: -
• Target version: -
• ruby -v: ruby 2.6.0dev (2018-10-04 trunk 64913)
• Backport: 2.3: UNKNOWN, 2.4: UNKNOWN, 2.5: UNKNOWN

[MSP-Greg (Greg L)]

Attached is a patch with fixes needed for the test-all WEBrick tests when run on Azure pipelines (vc12, vc14, mingw). These have not been needed for Appveyor builds, nor for local testing on mingw builds.

The changes involve line endings in three asserts.

Given that these haven't appeared before, I not sure what or where the fixes should be...

Thanks, Greg

[naruse (Yui NARUSE)]

• Status changed from Open to Closed

Applied in changeset trunk|r64924.

---

Use binread because webrick also uses binread

Reported-by: MSP-Greg [Bug #15203]

[naruse (Yui NARUSE)]

I think it's because git on Azure Pipeline enables "Use CRLF" option.
Because of that those test files uses CRLF on the environment.
WEBrick reads file on binary mode, therefore responses are also CRLF text.
But the expect data in those tests uses text mode read; this is the cause of this issue.
I fixed this by using binread on reading test expect data.