Project

General

Profile

Actions

Bug #15436

closed

Tests failing in `make check`

Added by ana06 (Ana Maria Martinez Gomez) over 5 years ago. Updated almost 5 years ago.

Status:
Closed
Assignee:
-
Target version:
-
ruby -v:
trunk branch in Github
[ruby-core:90619]

Description

The following tests fail when running check make (after make) in my openSUSE Tumbleweed using current Ruby trunk version:

[ 1080/19451] OpenSSL::TestEC#test_ec_point_mul = 0.00 s                                            
  1) Error:
OpenSSL::TestEC#test_ec_point_mul:
OpenSSL::PKey::EC::Point::Error: called a function you should not call
    /home/ana/github/ruby/test/openssl/test_pkey_ec.rb:312:in `mul'
    /home/ana/github/ruby/test/openssl/test_pkey_ec.rb:312:in `test_ec_point_mul'

[ 6846/19451] TestExtLibs#test_existence_of_fiddle = 0.07 s                                                                                    
  2) Failure:
TestExtLibs#test_existence_of_fiddle [/home/ana/github/ruby/test/test_extlibs.rb:20]:
extension library `fiddle' is not found
"pkg-config --exists libffi"
package configuration for libffi is not found
have_header: checking for ffi.h... -------------------- no

The second seems to be a problem package and not code related - a problem which I don't manage to solve.... :(
But I am not that sure with the first one.

Updated by jeremyevans0 (Jeremy Evans) over 5 years ago

ana06 (Ana Maria Martinez Gomez) wrote:

The following tests fail when running check make (after make) in my openSUSE Tumbleweed using current Ruby trunk version:

[ 1080/19451] OpenSSL::TestEC#test_ec_point_mul = 0.00 s                                            
  1) Error:
OpenSSL::TestEC#test_ec_point_mul:
OpenSSL::PKey::EC::Point::Error: called a function you should not call
    /home/ana/github/ruby/test/openssl/test_pkey_ec.rb:312:in `mul'
    /home/ana/github/ruby/test/openssl/test_pkey_ec.rb:312:in `test_ec_point_mul'

This failure also occurs in OpenBSD. It appears to be related to changes in LibreSSL to prevent a timing attack (https://github.com/openbsd/src/commit/149fe5183f483d61a4d9c7559eda5256da9eaf72#diff-0f7cc301aabeefcddcdcdccfb491d801). These changes do not appear to be in OpenSSL (https://github.com/openssl/openssl/blob/master/crypto/ec/ec_lib.c#L913).

Updated by shevegen (Robert A. Heiler) over 5 years ago

ffi could be found here as source package: ftp://sourceware.org/pub/libffi/libffi-3.2.1.tar.gz

That one also provides ffi.h; I assume opensuse has this also packaged up somewhere, possibly
a -dev/-devel package or something.

I don't know anything about the first error; thankfully Jeremy already commented above.

Updated by ana06 (Ana Maria Martinez Gomez) over 5 years ago

@shevegen (Robert A. Heiler) I had the package install.

I have just downloaded trunk again and it seems to work now... Maybe there was some related changes or maybe I didn't have the current version and I though I had

Anyway, it seems fixed

Updated by jeremyevans0 (Jeremy Evans) almost 5 years ago

  • Status changed from Open to Closed

The openssl issue was fixed by b8af33e63bd286308e5e1b20c182ec50e0f194de

The second issue was fixed earlier by installing FFI.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0