Project

General

Profile

Bug #15812

Run specs from install folder?

Added by MSP-Greg (Greg L) about 2 months ago. Updated about 2 months ago.

Status:
Open
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-core:92484]

Description

  1. Currently, no testing is done on the install folder.
  2. Configure/build & testing both take far longer than install
  3. spec tests normally run directly in their repo (ruby/spec)

GitHub PR 2160 https://github.com/ruby/ruby/pull/2160 runs the spec suite from the install folder for the three windows builds. All passed, and the tests were run parallel.

Given that the purpose is to create a functioning install folder, maybe a first step would be runnig specs from there?


Related issues

Related to Ruby trunk - Bug #15810: Windows spec failure - Process.ppid returns the process id of the parent of this process - ??ClosedActions
Related to Ruby trunk - Feature #13620: Simplifying MRI's build system: always make installOpenActions

History

Updated by Eregon (Benoit Daloze) about 2 months ago

I wholeheartedly agree with that.
Supporting running specs from the non-installed ruby is significant work and hacks.
And testing what people use in production rather than a temporary build is of course much more meaningful.

But I don't think many people agree to require running install to run specs/tests, unfortunately, see #13620.
Maybe we should do so that make creates an install-like layout in the first place with the build paths to e.g. libruby,
so that we can run tests there without e.g., needing miniruby and tool/run-ruby.rb?

We could require running tests from the install directory only for Windows if people agree.

spec tests normally run directly in their repo (ruby/spec)

They don't need to, it's perfectly fine to run specs from the copy under spec/ruby in the ruby repository.

#2

Updated by Eregon (Benoit Daloze) about 2 months ago

  • Related to Bug #15810: Windows spec failure - Process.ppid returns the process id of the parent of this process - ?? added
#3

Updated by Eregon (Benoit Daloze) about 2 months ago

  • Related to Feature #13620: Simplifying MRI's build system: always make install added

Also available in: Atom PDF