Run specs from install folder?
- Currently, no testing is done on the install folder.
- Configure/build & testing both take far longer than install
- spec tests normally run directly in their repo (ruby/spec)
GitHub PR 2160 https://github.com/ruby/ruby/pull/2160 runs the spec suite from the install folder for the three windows builds. All passed, and the tests were run parallel.
Given that the purpose is to create a functioning install folder, maybe a first step would be runnig specs from there?
Updated by Eregon (Benoit Daloze) almost 2 years ago
I wholeheartedly agree with that.
Supporting running specs from the non-installed
ruby is significant work and hacks.
And testing what people use in production rather than a temporary build is of course much more meaningful.
But I don't think many people agree to require running
install to run specs/tests, unfortunately, see #13620.
Maybe we should do so that
make creates an install-like layout in the first place with the build paths to e.g. libruby,
so that we can run tests there without e.g., needing miniruby and tool/run-ruby.rb?
We could require running tests from the install directory only for Windows if people agree.
spec tests normally run directly in their repo (ruby/spec)
They don't need to, it's perfectly fine to run specs from the copy under spec/ruby in the ruby repository.
Updated by Eregon (Benoit Daloze) over 1 year ago
- Assignee set to Eregon (Benoit Daloze)
- Status changed from Open to Closed
MSP-Greg (Greg L) I think it's OK to run specs after make-install if that is somehow better in CI.
I'd like to only support running specs on installed Ruby, but that's a separate issue: #13620.
I saw that you closed https://github.com/ruby/ruby/pull/2160.
Tell me if you want to add such a change, I can merge it.
I'll close this issue since the PR was closed, but please comment if you want it again.