Project

General

Profile

Bug #16349

Logger shift_age of 0 disables shift_size

Added by bughit (bug hit) about 1 month ago. Updated 28 days ago.

Status:
Closed
Priority:
Normal
Target version:
-
[ruby-core:95852]

Description

shift_age is documented as: Number of old log files to keep, or frequency of rotation (daily, weekly or monthly). Default value is 0.
shift_size is documented: Maximum logfile size in bytes (only applies when shift_age is a number). Defaults to 1048576 (1MB).

Given the above, a shift_age of 0 should prevent the retention of old log files, but maximum size (shift_size) should still be enforced.

But it's not: https://github.com/ruby/ruby/blob/master/lib/logger/log_device.rb#L124

So either the behavior or the documentation is wrong.

History

Updated by hsbt (Hiroshi SHIBATA) about 1 month ago

  • Assignee set to sonots (Naotoshi Seo)
  • Status changed from Open to Assigned

Updated by jeremyevans0 (Jeremy Evans) 28 days ago

I think this is a documentation bug, since the comment makes it explicit that shifting is always disabled if shift_age is 0. I submitted a pull request to update the documentation: https://github.com/ruby/logger/pull/43 .

#3

Updated by jeremyevans0 (Jeremy Evans) 28 days ago

  • Status changed from Assigned to Closed

Also available in: Atom PDF