when configuring --with-os-version-string=none fails to strip entire version string on MacOS
When configuring Ruby with
--with-os-version-string=none on Mac OS, the
target_os is set to
This is happening because the regex's generated by
configure.ac that form the
os_version_style_transform in the
configure script only handle a single major version digit. When this is run on Mac OS - where the target OS version is reported with a two digit major version (
19.2.0 on my Macbook Pro running Mac OS Catalina 10.15.2) - everything except the first half of the major version is removed.
This affects the value of the global constant
I believe the correct behaviour is to strip the entire version string rather than just part of it when the
none option is passed.
On a Machine running Mac OS, with the latest
master checked out, run:
autoconf && ./configure --with-os-version-style=none | grep -F 'target OS:'
this will output
* target OS: darwin1
Attached is a patch that fixes the regex to strip the entire version when
none is passed as an argument. After the patch is applied, when running the above command again the output should be:
* target OS: darwin