Project

General

Profile

Actions

Bug #16762

closed

Ruby is not properly fortified on armv7hl

Bug #16762: Ruby is not properly fortified on armv7hl

Added by vo.x (Vit Ondruch) over 5 years ago. Updated almost 5 years ago.

Status:
Closed
Target version:
-
ruby -v:
ruby 2.8.0dev (2020-04-03 master 810d66f3e7) [armv7hl-linux]
[ruby-core:97731]

Description

The issue is similar to #15335 and the fix is also similar:

diff --git a/coroutine/arm32/Context.S b/coroutine/arm32/Context.S
index b66db29622..596284b5cf 100644
--- a/coroutine/arm32/Context.S
+++ b/coroutine/arm32/Context.S
@@ -24,3 +24,7 @@ coroutine_transfer:
 	
 	# Restore callee state (8 registers program counter)
 	pop {r4-r11,pc}
+
+#if defined(__linux__) && defined(__ELF__)
+.section .note.GNU-stack,"",%progbits
+#endif

It seems to be introduced by https://github.com/ruby/ruby/pull/2995


Related issues 1 (0 open1 closed)

Related to Ruby - Bug #15335: Ruby 2.6.0 is not properly fortifiedClosedioquatix (Samuel Williams)Actions

Updated by vo.x (Vit Ondruch) over 5 years ago Actions #1

  • Related to Bug #15335: Ruby 2.6.0 is not properly fortified added

Updated by vo.x (Vit Ondruch) about 5 years ago Actions #2 [ruby-core:100347]

I'd still love to see this fixed.

Updated by mame (Yusuke Endoh) about 5 years ago Actions #3 [ruby-core:100349]

  • Status changed from Open to Assigned
  • Assignee set to ioquatix (Samuel Williams)

Updated by ioquatix (Samuel Williams) almost 5 years ago Actions #5 [ruby-core:101314]

It passed arm32 on travis (as expected), so I merged it. Thanks everyone!

Updated by ioquatix (Samuel Williams) almost 5 years ago Actions #6

  • Status changed from Assigned to Closed
Actions

Also available in: PDF Atom