Project

General

Profile

Actions
Copy link

Bug #16826

closed

ObjectSpace::WeakMap#key? returns false if value is nil

Bug #16826: ObjectSpace::WeakMap#key? returns false if value is nil

Added by Eregon (Benoit Daloze) over 5 years ago. Updated over 5 years ago.

Status:
Closed
Assignee:
Eregon (Benoit Daloze)
Target version:
-
ruby -v:
ruby 2.7.1p83 (2020-03-31 revision a0c7c23c9c) [x86_64-linux]
Backport:
2.5: DONTNEED, 2.6: DONTNEED, 2.7: DONE
[ruby-core:98118]

Description

$ ruby -e 'map=ObjectSpace::WeakMap.new; map[:foo] = 4; p map; p map.key? :foo'  
#<ObjectSpace::WeakMap:0x000055fbe0c38c00: :foo => 4>
true # OK

$ ruby -e 'map=ObjectSpace::WeakMap.new; map[:foo] = nil; p map; p map.key? :foo'
#<ObjectSpace::WeakMap:0x000056371e3f86e8: :foo => nil>
false # BUG

Updated by Eregon (Benoit Daloze) over 5 years ago Actions
Copy link
 #1 [ruby-core:98119]

  • Assignee set to Eregon (Benoit Daloze)

I'll fix this.

Updated by Eregon (Benoit Daloze) over 5 years ago Actions
Copy link
 #2

  • Status changed from Open to Closed

Applied in changeset git|a2be428c5fec31b8adbd5ac087e7637ddf7e54d0.

Fix ObjectSpace::WeakMap#key? to work if the value is nil

Updated by nagachika (Tomoyuki Chikanaga) over 5 years ago Actions
Copy link
 #3 [ruby-core:99288]

  • Backport changed from 2.5: DONTNEED, 2.6: DONTNEED, 2.7: REQUIRED to 2.5: DONTNEED, 2.6: DONTNEED, 2.7: DONE

ruby_2_7 9da6470d7b3aa136b4b92469c8bbc522beb1ac31 merged revision(s) a2be428c5fec31b8adbd5ac087e7637ddf7e54d0.

Actions
Copy link

Also available in: PDF Atom