Project

General

Profile

Actions

Feature #17099

open

Remove boolean argument and warning from Module#attr

Added by S_H_ (Shun Hiraoka) about 1 year ago. Updated 9 months ago.

Status:
Open
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-dev:50944]

Description

Module#attr works as Module#attr_reader by default (since in 1.9.1). Its optional boolean argument is obsoleted, but it works as Module#attr_writer when its value is true.

I think it's okay to remove the optional boolean argument and the warning from Module#attr.

pull request:
https://github.com/ruby/ruby/pull/3386

Actions #1

Updated by S_H_ (Shun Hiraoka) about 1 year ago

  • Description updated (diff)
Actions #2

Updated by sawa (Tsuyoshi Sawada) about 1 year ago

  • Description updated (diff)
  • Subject changed from Remove Module#attr warning with given boolean argument to Remove boolean argument and warning from Module#attr

Updated by S_H_ (Shun Hiraoka) about 1 year ago

Anyone has opinion?

Updated by nobu (Nobuyoshi Nakada) 9 months ago

It has not been warned unless $VERBOSE yet.
We may need wait one more release if we obey the previous rule.
But deprecations aren't warned even if $VERBOSE since 2.7.2, I think we can reconsider that rule.

Actions

Also available in: Atom PDF