Bug #17396: Missing .gemspec files

• Status: Closed
• Assignee: -
• Target version: -
• ruby -v: ruby 3.0.0dev (2020-12-16 master a9a7f4d8b8) [x86_64-linux]
• Backport: 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN

[vo.x (Vit Ondruch)]

I am missing every .gemspec file, which used to be installed by bundled gems. IOW previously there were installed files such as rexml.gemspec and rss.gemspec. This is presumably caused by 91f831ac17c8ff58d536ce1fa320294bb477d2ae. But I really wonder why the rbinstall mangles upstream package content? If the .gemspec should not be shipped, then this should be solved by upstream. If this causes some issues to test suite, the test suite should be probably fixed by different means IMO (not mentioning that the commit message is not really clear what was the issue on the first place).

BTW I have opened more then year ago this PR 1 where RubyGems are used to install the bundled gems and it does not get too much response. I'd still like to see this merged.

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Closed

Gem files contain metadata processed from gemspec files, other than the source gemspecs.
The source often contains some code which do not make sense in its upstream working directory, e.g., git ls-files.
As well as gem install uses the metadata and ignores gemspec files, we need the same metadata.
The versioned file in that commit is extracted this metadata, not the shipped gemspec file itself, so "the rbinstall does not mangle upstream package content".

[vo.x (Vit Ondruch)]

When the .gem file contains .gemspec file, then it should be installed by rbinstall.

$ gem unpack rexml
Fetching rexml-3.2.4.gem
Unpacked gem: '/home/vondruch/rexml-3.2.4'

$ find rexml-3.2.4/ | grep gemspec
rexml-3.2.4/rexml.gemspec

If the .gemspec file should not be included in the .gem file, that is different discussion, which should be held either the package upstream or RubyGems upstream.