Project

General

Profile

Actions
Copy link

Bug #17639

closed

TYPO in define constant

Added by YO4 (Yoshinao Muramatsu) almost 4 years ago. Updated over 3 years ago.

Status:
Closed
Assignee:
-
Target version:
-
ruby -v:
Backport:
2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: DONE
[ruby-dev:51025]

Description

ソース内で下記の定義が行われていますが、ENABLE_VIRTUAL_TERMINAL_PROCESSING は正しくは 4 です。

#ifndef ENABLE_VIRTUAL_TERMINAL_PROCESSING
#define ENABLE_VIRTUAL_TERMINAL_PROCESSING 0x200
#endif

コンパイルした環境のシステムヘッダに依存して挙動が変わる場合がありうるので、バイナリによって挙動が違う困ったことが起こりえます。

パッチは github の master が対象で、ruby.c win32/win32.c の2ファイルを変更しています。

Files

ENABLE_VIRTUAL_TERMINAL_PROCESSING.diff (1.16 KB) ENABLE_VIRTUAL_TERMINAL_PROCESSING.diff YO4 (Yoshinao Muramatsu), 02/17/2021 04:04 PM
Actions
Copy link
 #1

Updated by nobu (Nobuyoshi Nakada) almost 4 years ago

  • Backport changed from 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: UNKNOWN to 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: REQUIRED
Actions
Copy link
 #2

Updated by YO4 (Yoshinao Muramatsu) almost 4 years ago

  • Status changed from Open to Closed

Applied in changeset git|b94b7965c420661ed621c146a4efaf43bc3cf50b.

Fixed fallback ENABLE_VIRTUAL_TERMINAL_PROCESSING value [Bug #17639]

Actions
Copy link
 #3 [ruby-dev:51052]

Updated by nagachika (Tomoyuki Chikanaga) over 3 years ago

  • Backport changed from 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: REQUIRED to 2.5: UNKNOWN, 2.6: UNKNOWN, 2.7: UNKNOWN, 3.0: DONE

The fix was already backported at 3e67bfe202d6b410375af990ac806f15cb2df762.

Actions
Copy link

Also available in: Atom PDF

Like0
Like0Like0Like0