Project

General

Profile

Actions

Bug #18191

closed

All loaded feature filenames should be in the file system encoding

Added by NuriYuri (Youri Nouri) about 1 month ago. Updated 17 days ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-core:105416]

Description

I don't know if that has already been fixed but it seems that few internal variables ($LOADED_FEATURES) are still containing paths announced as BINARY instead of UTF-8. (While their content is actually UTF-8 Data).

Here's some evidence of the issue:
https://www.zupimages.net/up/21/38/g8a0.png

p $LOADED_FEATURES[5]
=> "D:/nuriy/Work/pok\xC3\xA9monsdk/lib/ruby/3.0.0/i386-mingw32/enc/encdb.so"
p $LOADED_FEATURES[5].encoding
=> #<Encoding:ASCII-8BIT>

Here's the fix I made to prevent the issue: https://gitlab.com/pokemonsdk/pokemonsdk/-/commit/c9b27ecad1c4b5016e2ef56a3f1df25e74395ce4
I believe that it can be fixed by setting the right encoding in the generated string object when $LOADED_FEATURES is filled.

ruby -v: ruby 3.0.1p64 (2021-04-05 revision 0fb782ee38) [i386-mingw32]
Content of psdk.bat: ruby.exe --disable=gems,rubyopt,did_you_mean Game.rb %*

Actions #1

Updated by nobu (Nobuyoshi Nakada) 28 days ago

  • Backport set to 2.6: UNKNOWN, 2.7: REQUIRED, 3.0: REQUIRED
  • Tracker changed from Misc to Bug

Updated by nobu (Nobuyoshi Nakada) 27 days ago

  • Subject changed from All internal filenames should be in UTF-8 to All loaded feature filenames should be in the file system encoding
  • $LOADED_FEATURES elements are not all of the "internal" strings.
  • These should be in the file system, may not be UTF-8.
Actions #3

Updated by nobu (Nobuyoshi Nakada) 25 days ago

  • Status changed from Open to Closed

Applied in changeset git|60d0421ca861944459f52292d65dbf0ece26e38a.


Fix the encoding of loaded feature names [Bug #18191]

The feature names loaded from the default load paths should also
be in the file system encoding.

Updated by nagachika (Tomoyuki Chikanaga) 17 days ago

  • Backport changed from 2.6: UNKNOWN, 2.7: REQUIRED, 3.0: REQUIRED to 2.6: UNKNOWN, 2.7: REQUIRED, 3.0: DONE

ruby_3_0 2c947e74a0a11fe6c54253c15224dc80054c62a2 merged revision(s) 60d0421ca861944459f52292d65dbf0ece26e38a,b6534691a16d751d59fc572d5dddebcaeb21f007,409dbc951b9875d27bd73748c88e15386473cffb,842b0008c132dd587f09766a228041afb7fed24f.

Actions

Also available in: Atom PDF