Project

General

Profile

Actions

Bug #18394

closed

Backports for read barrier for GC compaction for Ruby 3.0

Added by peterzhu2118 (Peter Zhu) 10 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-core:106540]

Description

Please backport commits 0130e17a410d60a10e7041ce98748b8de6946971 and 32b7dcfb56a417c1d1c354102351fc1825d653bf to Ruby 3.0.

The read barrier is required for both manual and automatic compaction. Not setting up the read barrier can cause crashes such as #18133.

Edit:

In addition to the two commits above, please also backport the attached patch. The attached patch switches posix_memalign to mmap for allocation of pages.


Files

mmap.patch (11.1 KB) mmap.patch peterzhu2118 (Peter Zhu), 12/15/2021 02:37 PM

Related issues 1 (0 open1 closed)

Related to Ruby master - Bug #18746: /TestGCCompact#test_(ast_compacts|compact_count|complex_hash_keys|gc_compact_stats)/ fails on PPCClosedActions
Actions #1

Updated by peterzhu2118 (Peter Zhu) 10 months ago

  • Description updated (diff)
  • File mmap.patch added
Actions #2

Updated by peterzhu2118 (Peter Zhu) 10 months ago

  • File deleted (mmap.patch)

Updated by nagachika (Tomoyuki Chikanaga) 7 months ago

  • Backport changed from 2.6: DONTNEED, 2.7: DONTNEED, 3.0: REQUIRED to 2.6: DONTNEED, 2.7: DONTNEED, 3.0: DONE

ruby_3_0 3ce60f44b8de3aabb31c37d2afd2a622a64a3e6f merged revision(s) 0130e17a410d60a10e7041ce98748b8de6946971,32b7dcfb56a417c1d1c354102351fc1825d653bf,79cc566ab4cdf75f125ecf413a27d353a9756c08.

Actions #5

Updated by vo.x (Vit Ondruch) 6 months ago

  • Related to Bug #18746: /TestGCCompact#test_(ast_compacts|compact_count|complex_hash_keys|gc_compact_stats)/ fails on PPC added

Updated by peterzhu2118 (Peter Zhu) 6 months ago

  • Backport changed from 2.6: DONTNEED, 2.7: DONTNEED, 3.0: DONE to 2.6: DONTNEED, 2.7: DONTNEED, 3.0: REQUIRED

Changing the backport status of Ruby 3.0 to "REQUIRED" again because it doesn't look like the attached patched was applied.

Actions

Also available in: Atom PDF