Project

General

Profile

Actions

Bug #18938

closed

Backport cf7d07570f50ef9c16007019afcff11ba6500d70

Added by byroot (Jean Boussier) 5 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
-
[ruby-core:109314]

Description

Please backport https://github.com/ruby/ruby/commit/cf7d07570f50ef9c16007019afcff11ba6500d70 which fixes a bug in ObjectSpace.dump for Ruby 3.0 and Ruby 3.1

Ref: https://github.com/ruby/ruby/pull/6166

cc @nobu (Nobuyoshi Nakada)

Actions #1

Updated by byroot (Jean Boussier) 5 months ago

  • Subject changed from Backport cf7d07570f50ef9c16007019afcff11ba6500d70 to Backport c6aa65430fbb94651f4d15e2a976f59b5475ca19
  • Description updated (diff)

Updated by nagachika (Tomoyuki Chikanaga) 3 months ago

I tried to backport cf7d07570f50ef9c16007019afcff11ba6500d70 and c6aa65430fbb94651f4d15e2a976f59b5475ca19 into ruby_3_1 branch, but the test test_utf8_method_names failed. Maybe some more changesets are needed. I will investigate it further.

TestObjSpace#test_utf8_method_names:
JSON::ParserError: 859: unexpected token at '{"address":"0x10465a248", "type":"STRING", "class":"0x101cf2450", "embedded":true, "bytesize":2, "value":"12", "encoding":"UTF-8", "file":"/Users/nagachika/opt/ruby-3.1/src/ruby_3_1/test/objspace/test_objspace.rb", "line":649, "method":"utf8_\u00ff'
    /Users/nagachika/opt/ruby-3.1/src/build/.ext/common/json/common.rb:216:in `parse'
    /Users/nagachika/opt/ruby-3.1/src/build/.ext/common/json/common.rb:216:in `parse'
    /Users/nagachika/opt/ruby-3.1/src/ruby_3_1/test/objspace/test_objspace.rb:642:in `test_utf8_method_names'

Updated by byroot (Jean Boussier) 3 months ago

  • Subject changed from Backport c6aa65430fbb94651f4d15e2a976f59b5475ca19 to Backport cf7d07570f50ef9c16007019afcff11ba6500d70
  • Description updated (diff)

@nagachika (Tomoyuki Chikanaga) it's my fault. For backporting purpose cf7d07570f50ef9c16007019afcff11ba6500d70 alone should be backported and c6aa65430fbb94651f4d15e2a976f59b5475ca19 should be ignored.

Updated by nagachika (Tomoyuki Chikanaga) 3 months ago

I have got the same error with only backporting cf7d07570f50ef9c16007019afcff11ba6500d70.

Updated by byroot (Jean Boussier) 3 months ago

I don't understand, it works fine on my machine. I made two backport PRs, maybe it doesn't work on some system and CI will catch it?

Updated by nagachika (Tomoyuki Chikanaga) 3 months ago

I tested on ruby_3_1 branch.
I'm afraid I failed to rebuild extensions before run make test-all on my environments.

Updated by nagachika (Tomoyuki Chikanaga) 3 months ago

  • Backport changed from 2.7: DONTNEED, 3.0: REQUIRED, 3.1: REQUIRED to 2.7: DONTNEED, 3.0: REQUIRED, 3.1: DONE

ruby_3_1 e46532feafadef252682794c941180df72483c19 merged revision(s) cf7d07570f50ef9c16007019afcff11ba6500d70.

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0Like0Like0