Project

General

Profile

Actions

Bug #19266

open

URI::Generic should use URI::RFC3986_PARSER instead of URI::DEFAULT_PARSER

Added by gareth (Gareth Adams) over 1 year ago. Updated 11 days ago.

Status:
Open
Assignee:
-
Target version:
-
ruby -v:
ruby 3.1.3p185 (2022-11-24 revision 1a6b16756e) [arm64-darwin21]
[ruby-core:111448]

Description

In June 2014, uri/common was updated to introduce a RFC3986-compliant parser (URI::RFC3986_PARSER) as an alternative to the previous RFC2396 parser, and common methods like URI() were updated to use that new parser by default. The only methods in common not updated were URI.extract and URI.regexp which are marked as obsolete. (The old parser was kept in the DEFAULT_PARSER constant despite it not being the default for those methods, presumably for backward compatibility.)

However, similar methods called on URI::Generic were never updated to use this new parser. This means that methods like URI::Generic.build fail when given input that succeeds normally, and this also affects subclasses like URI::HTTP:

$ pry -r uri -r uri/common -r uri/generic

[1] pry(main)> URI::Generic.build(host: "underscore_host.example")
URI::InvalidComponentError: bad component(expected host component): underscore_host.example
from /Users/gareth/.asdf/installs/ruby/3.1.3/lib/ruby/3.1.0/uri/generic.rb:591:in `check_host'

[2] pry(main)> URI::HTTP.build(host: "underscore_host.example")
URI::InvalidComponentError: bad component(expected host component): underscore_host.example
from /Users/gareth/.asdf/installs/ruby/3.1.3/lib/ruby/3.1.0/uri/generic.rb:591:in `check_host'

[3] pry(main)> URI("http://underscore_host.example")
=> #<URI::HTTP http://underscore_host.example>

URI::Generic.new allows a configurable parser positional argument to override the class' default parser, but other factory methods like .build don't allow this override.

Arguably this doesn't cause problems because at least in the case above, the URI can be built with the polymorphic constructor, but having the option to build URIs from explicit named parts is useful, and leaving the outdated functionality in the Generic class is ambiguous. It's possible that the whole Generic class and its subclasses aren't intended to be used directly how I'm intending here, but there's nothing I could see that suggested this is the case.

I'm not aware of the entire list of differences between RFC2396 and RFC3986. The relevant difference here is that in RFC2396 an individual segment of a host (domainlabels) could only be alphanum | alphanum *( alphanum | "-" ) alphanum, whereas RFC3986 allows hostnames to include any of ALPHA / DIGIT / "-" / "." / "_" / "~". It's possible that other differences might cause issues for developers, but since this has gone over 8 years without anyone else caring about this, this is definitely not especially urgent.


Files


Related issues 1 (1 open0 closed)

Related to Ruby master - Bug #19756: URI::HTTP.build does not accept a host of `_gateway`, but `URI.parse` will.OpenActions

Updated by gareth (Gareth Adams) over 1 year ago

The attached patch adds a failing test and a change that fixes it.

The rest of the test suite passes with this patch.

Updated by gareth (Gareth Adams) over 1 year ago

After a couple of weeks with no reply I wanted to ask if I could get at least one comment on this issue?

A quick summary of the issue:

  • In 2014, URI was updated to use a new RFC3986-compliant parser by default instead of the previous RFC2396 parser.
  • Two methods inside URI::Generic (build and build2) were not updated to use the new parser, they are hardcoded to the old parser.
  • These two methods are used by subclasses like URI::HTTP, for building URIs from parts: URI::HTTP.build(host: "foobar.com")
  • The main significant difference is that the old parser fails with hostnames including underscores, which are now valid.

This issue was to fix these two methods, which are probably rarely used in comparison to URI() but are still useful.

  • The issue has a patch attached.
  • The patch resolves the issue, includes a test, and doesn't fail any other tests.
  • The total diff is just +10 -6.

This is a very minor issue, which is probably why it's gone unnoticed for 8 years, but the fix is also very isolated and hopefully very low risk.

Thanks,
Gareth

Updated by jeremyevans0 (Jeremy Evans) 2 months ago

I'm in favor of this change. However, be aware that uri is maintained at https://github.com/ruby/uri . Could you please submit a pull request to that repository?

Actions #4

Updated by jeremyevans0 (Jeremy Evans) 2 months ago

  • Related to Bug #19756: URI::HTTP.build does not accept a host of `_gateway`, but `URI.parse` will. added

Updated by gareth (Gareth Adams) 11 days ago

jeremyevans0 (Jeremy Evans) wrote in #note-3:

I'm in favor of this change. However, be aware that uri is maintained at https://github.com/ruby/uri . Could you please submit a pull request to that repository?

Thanks Jeremy, I've replicated this patch in https://github.com/ruby/uri/pull/105 if you're happy with the change :)

Gareth

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0