Bug #19349
closedKernel.Integer silently discards base argument that does not have a #to_int
Description
The method Kernel.Integer
has an optional argument base
, which is the base to convert the input to:
irb(main):001:0> Kernel.Integer('10', 8)
=> 8
If the base argument is not an integer, it is converted using #to_int
irb(main):002:0> Kernel.Integer('10', 8.2)
=> 8
irb(main):003:0> Kernel.Integer('10', Object.new.tap { |x| x.define_singleton_method(:to_int) { 8 } })
=> 8
But if the base argument is not an Integer, and does not have a #to_int
method, it gets discarded
irb(main):004:0> Kernel.Integer('10', '8')
=> 10
I would expect this to raise a TypeError
, similar to String#to_i
:
irb(main):005:0> '10'.to_i('8')
(irb):5:in `to_i': no implicit conversion of String into Integer (TypeError)
This has briefly been discussed on the ruby-spec github repo, and they suggested to report this as a bug. (see https://github.com/ruby/spec/pull/997#issuecomment-1382825900)
Updated by herwin (Herwin W) over 2 years ago
And likely related: in case the output of the call to to_int
returns something that is not an integer, it gets discarded as well
Kernel.Integer('10', Object.new.tap { |x| x.define_singleton_method(:to_int) { '8' } })
=> 10
Updated by nobu (Nobuyoshi Nakada) over 2 years ago
Updated by nobu (Nobuyoshi Nakada) over 1 year ago
- Status changed from Open to Closed
Applied in changeset git|c45176dbca2bd082cb199e9411e4dfc5ec162352.
[Bug #19349] Respect #to_int
of base
argument