Bug #19426: Endless `Range#step` of object with `#succ` method does not work

• Status: Closed
• Assignee: -
• Target version: -
• Backport: 2.7: REQUIRED, 3.0: REQUIRED, 3.1: REQUIRED, 3.2: DONE

[nobu (Nobuyoshi Nakada)]

Consider this c object which hash #succ method.

c = Struct.new(:i) do
  def succ; self.class.new(i+1); end
  def <=>(other) i <=> other.i;end
end.new(0)

This Range#step works.

(c..c.succ).step(1) do |d|
  p d.i # 0, 1
end

But it fails on an endless range.

(c..).step(1) do |d|
  p d.i
  break if d.i > 3
end

-:3:in `<=>': undefined method `i' for nil:NilClass (NoMethodError)
	from -:10:in `step'
	from -:10:in `<main>'

[nobu (Nobuyoshi Nakada)]

• Backport changed from 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN to 2.7: REQUIRED, 3.0: REQUIRED, 3.1: REQUIRED, 3.2: REQUIRED

[matz (Yukihiro Matsumoto)]

• Status changed from Open to Closed

Error was caused because the definition of <=> does not conform to the expectation that it should return nil for incomparable objects.

Matz.

[nobu (Nobuyoshi Nakada)]

Sorry that I merged the PR before seeing the reply.

With the same object, Range#each works as expected.

(c..).each do |d|
  p d.i
  break if d.i > 3
end

This is because c is not compared against nil first.
I think #step should behave like this.

[nobu (Nobuyoshi Nakada)]

• Status changed from Closed to Open

[matz (Yukihiro Matsumoto)]

I agree with moving nil comparison.

Matz.

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Closed

[hsbt (Hiroshi SHIBATA)]

• Backport changed from 2.7: REQUIRED, 3.0: REQUIRED, 3.1: REQUIRED, 3.2: REQUIRED to 2.7: REQUIRED, 3.0: REQUIRED, 3.1: REQUIRED, 3.2: DONE

ruby_3_2 commit:89eacd31b7565aa45b9c9af4b475cf908830e41c merged revision(s) da4464b824857d7610f9865ceb452ce0ead49164.