Project

General

Profile

Actions

Bug #20597

closed

`eval('break if false')` should raise SyntaxError but retuns nil

Added by tompng (tomoya ishida) 5 months ago. Updated 2 months ago.

Status:
Closed
Assignee:
-
Target version:
-
ruby -v:
ruby 3.4.0dev (2024-06-27T13:47:22Z master c6a0d03649) [x86_64-linux]
[ruby-core:118398]

Description

These are all SyntaxError (Invalid break, compile error (SyntaxError))

ruby -ce "break if false"
ruby -ce "break if (false)"
ruby -ce "break if nil"
ruby -ce "break if (nil)"
ruby -ce "break if 0>1"

But when it is passed to eval, some of them does not raise SyntaxError but return nil.

eval('break if false') #=> nil
eval('break if (false)') #=> nil
eval('break if nil') #=> nil
eval('break if (nil)') #=> Can't escape from eval with break (SyntaxError)
eval('break if 0>1') #=> Can't escape from eval with break (SyntaxError)

Same behavior with next redo and yield

Updated by jeremyevans0 (Jeremy Evans) 5 months ago

I submitted a pull request to fix this (but prism still needs a related fix) https://github.com/ruby/ruby/pull/11099

Actions #2

Updated by jeremyevans (Jeremy Evans) 2 months ago

  • Status changed from Open to Closed

Applied in changeset git|268c72377b06b7d84a0998ca241340d0f58768f6.


Raise a compile error for break/next/redo inside eval in cases where it is optimized away

In cases where break/next/redo are not valid syntax, they should
raise a SyntaxError even if inside a conditional block that is
optimized away.

Fixes [Bug #20597]

Co-authored-by: Kevin Newton

Actions

Also available in: Atom PDF

Like0
Like0Like0