Bug #20734: Test failure at FreeBSD 14.1

• Status: Closed
• Assignee: byroot (Jean Boussier)
• Target version: -
• Backport: 3.1: DONTNEED, 3.2: DONTNEED, 3.3: DONTNEED

[hsbt (Hiroshi SHIBATA)]

FreeBSD 14.1 build is also failure with ruby master. This is different error from #20733

[hsbt@freebsd ~/ruby]$ make
        BASERUBY = /usr/local/bin/ruby --disable=gems
        CC = clang
        LD = ld
        LDSHARED = clang -shared
        CFLAGS = -fstack-protector-strong -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fdeclspec  -O3 -fno-fast-math -ggdb3 -Wall -Wextra -Wextra-tokens -Wdeprecated-declarations -Wdivision-by-zero -Wdiv-by-zero -Wimplicit-function-declaration -Wimplicit-int -Wpointer-arith -Wshorten-64-to-32 -Wwrite-strings -Wold-style-definition -Wmissing-noreturn -Wno-cast-function-type -Wno-constant-logical-operand -Wno-long-long -Wno-missing-field-initializers -Wno-overlength-strings -Wno-parentheses-equality -Wno-self-assign -Wno-tautological-compare -Wno-unused-parameter -Wno-unused-value -Wunused-variable -Wmisleading-indentation -Wundef
        XCFLAGS = -fno-strict-overflow -fvisibility=hidden -fexcess-precision=standard -DRUBY_EXPORT -fPIE -I. -I.ext/include/amd64-freebsd14.1 -I./include -I. -I./prism -I./enc/unicode/15.0.0
        CPPFLAGS =
        DLDFLAGS = -Wl,--compress-debug-sections=zlib -Wl,-soname,showflags -fstack-protector-strong -pie
        SOLIBS = -lexecinfo -lprocstat -lz -lrt -lrt -ldl -lcrypt -lm -lthr
        LANG = C.UTF-8
        LC_ALL =
        LC_CTYPE =
        MFLAGS =
        RUSTC = rustc
        YJIT_RUSTC_ARGS = --crate-name=yjit  --crate-type=staticlib  --edition=2021  -g  -C lto=thin  -C opt-level=3  -C overflow-checks=on  '--out-dir=/home/hsbt/ruby/yjit/target/release/'  ./yjit/src/lib.rs
FreeBSD clang version 18.1.5 (https://github.com/llvm/llvm-project.git llvmorg-18.1.5-0-g617a15a9eac9)
Target: x86_64-unknown-freebsd14.1
Thread model: posix
InstalledDir: /usr/bin
compiling version.c
In file included from version.c:14:
./version.h:29:5: error: invalid suffix 'RUBY_RELEASE_MONTH' on integer constant
   29 | #if ONLY_ONE_DIGIT(RUBY_RELEASE_MONTH)
      |     ^
./version.h:25:27: note: expanded from macro 'ONLY_ONE_DIGIT'
   25 | #define ONLY_ONE_DIGIT(x) TOKEN_PASTE(10,x) < 1000
      |                           ^
./include/ruby/internal/config.h:37:26: note: expanded from macro 'TOKEN_PASTE'
   37 | #define TOKEN_PASTE(x,y) x##y
      |                          ^
<scratch space>:156:3: note: expanded from here
  156 | 10RUBY_RELEASE_MONTH
      |   ^
In file included from version.c:14:
./version.h:34:5: error: invalid suffix 'RUBY_RELEASE_DAY' on integer constant
   34 | #if ONLY_ONE_DIGIT(RUBY_RELEASE_DAY)
      |     ^
./version.h:25:27: note: expanded from macro 'ONLY_ONE_DIGIT'
   25 | #define ONLY_ONE_DIGIT(x) TOKEN_PASTE(10,x) < 1000
      |                           ^
./include/ruby/internal/config.h:37:26: note: expanded from macro 'TOKEN_PASTE'
   37 | #define TOKEN_PASTE(x,y) x##y
      |                          ^
<scratch space>:157:3: note: expanded from here
  157 | 10RUBY_RELEASE_DAY
      |   ^
2 errors generated.
*** Error code 1

Stop.
make: stopped in /home/hsbt/ruby

[hsbt (Hiroshi SHIBATA)]

I could build 4ca588eede and git clean -fxd.

But Ruby CI is still stopped from Sep 5th.

https://rubyci.s3.amazonaws.com/freebsd14/ruby-master/recent.html

I'm investigating now.

[hsbt (Hiroshi SHIBATA)]

• Subject changed from Build failure at FreeBSD 14.1 to Test failure at FreeBSD 14.1
• Status changed from Open to Assigned
• Assignee set to byroot (Jean Boussier)

I confirmed that https://github.com/ruby/ruby/commit/63cbe3f6ac9feb44a2e43b1f853e2ca7e049316c is not working with FreeBSD 14.

$ make btest
2024-09-19 04:08:20 +0000
Driver is ruby 3.2.4 (2024-04-23 revision af471c0e01) [amd64-freebsd14]
Target is ruby 3.4.0dev (2024-09-17T03:54:00Z master 4ca588eede) +PRISM [amd64-freebsd14.1]

test_attr.rb              PASS 3
test_autoload.rb          PASS 8
test_block.rb             PASS 58
test_class.rb             PASS 48
test_constant_cache.rb    PASS 10
test_env.rb               PASS 2
test_eval.rb              PASS 49
test_exception.rb         PASS 34
test_fiber.rb             PASS 6
test_finalizer.rb         PASS 2
test_flip.rb              PASS 1
test_flow.rb              PASS 62
#284 test_fork.rb:1:
     begin
       GC.stress = true
       pid = fork {}
       Process.wait pid
       $?.to_i
     rescue NotImplementedError
       0
     end
  #=> "134" (expected "0")  [ruby-dev:32404]
stderr output is not empty
   bootstraptest.test_fork.rb_1_284.rb:6: [BUG] pthread_rwlock_unlock: Operation not permitted (EPERM)
   ruby 3.4.0dev (2024-09-17T03:54:00Z master 4ca588eede) +PRISM [amd64-freebsd14.1]

full log is here: https://gist.github.com/hsbt/cf8d52921d895fab31c66909a3db5537 (It's over the 70000 lines)

I also confirm make btest at FreeBSD 14 is working with reverting https://github.com/ruby/ruby/commit/63cbe3f6ac9feb44a2e43b1f853e2ca7e049316c.

@byroot (Jean Boussier) Can you look this?

[hsbt (Hiroshi SHIBATA)]

• Related to Feature #20590: Ensure `fork` isn't called when `raddrinfo`'s background thread is in `getaddrinfo` added

[hsbt (Hiroshi SHIBATA)]

• Status changed from Assigned to Closed
• Backport changed from 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN to 3.1: DONTNEED, 3.2: DONTNEED, 3.3: DONTNEED

@nobu (Nobuyoshi Nakada) fixed this at https://github.com/ruby/ruby/commit/dc8c382266b056fa51408806478218f5230fbce2