Project

General

Profile

Actions

Bug #20737

closed

Accidentally changed warning target on Ruby 3.3

Added by hsbt (Hiroshi SHIBATA) 10 months ago. Updated 8 months ago.

Status:
Closed
Assignee:
-
Target version:
-
[ruby-core:119165]

Description

I heard that concern from yhonda.

I request to backport bundled_gems.rb that is same version of the current master. After that, Ruby 3.3.5 show warnings when some default gems was loaded.

https://github.com/ruby/ruby/blob/ruby_3_3/lib/bundled_gems.rb#L29-L34

I should warn them for future update. But this change shouldn't introduce tiny/patch update from 3.3.4.

@k0kubun (Takashi Kokubun) What's your opinion about that? I will create pull-request if we suppress warns for Ruby 3.5.

Updated by k0kubun (Takashi Kokubun) 10 months ago

Makes sense. Let's revert that back to the Ruby 3.3.4 one in Ruby 3.3.6.

Updated by hsbt (Hiroshi SHIBATA) 10 months ago

  • Status changed from Open to Closed
  • Backport changed from 3.1: UNKNOWN, 3.2: UNKNOWN, 3.3: UNKNOWN to 3.1: DONTNEED, 3.2: DONTNEED, 3.3: REQUIRED

Updated by Eregon (Benoit Daloze) 10 months ago ยท Edited

Agreed, I didn't expect new warnings in 3.3.5 when 3.3.4 did not warn, and extra warnings can break CI (e.g. #20713).

Actions #4

Updated by k0kubun (Takashi Kokubun) 8 months ago

  • Backport changed from 3.1: DONTNEED, 3.2: DONTNEED, 3.3: REQUIRED to 3.1: DONTNEED, 3.2: DONTNEED, 3.3: DONE
Actions

Also available in: Atom PDF

Like1
Like1Like0Like0Like0