Bug #21697: `nmake up` will update broken `revision.h`

• Status: Open
• Assignee: -
• Target version: -
• Backport: 3.2: UNKNOWN, 3.3: UNKNOWN, 3.4: UNKNOWN

[hsbt (Hiroshi SHIBATA)]

In 4.0.0-preview2 package, nmake up generate the broken revision.h.

I could reproduce this:

PS C:\Users\hsbt\Downloads> Invoke-WebRequest https://cache.ruby-lang.org/pub/ruby/4.0/ruby-4.0.0-preview2.zip -OutFile ruby-4.0.0-preview2.zip
(snip)
PS C:\Users\hsbt\Downloads> unzip .\ruby-4.0.0-preview2.zip
                                                           Archive:  ./ruby-4.0.0-preview2.zip
   creating: ruby-4.0.0-preview2/
(snip)
  inflating: ruby-4.0.0-preview2/zjit.rbinc
PS C:\Users\hsbt\Downloads> cd .\ruby-4.0.0-preview2

PS C:\Users\hsbt\Downloads\ruby-4.0.0-preview2> cmd /k "C:\Program Files (x86)\Microsoft Visual Studio\18\BuildTools\VC\Auxiliary\Build\vcvars64.bat"

hsbt@LAPLACE C:\Users\hsbt\Downloads\ruby-4.0.0-preview2>type revision.h
#define RUBY_REVISION "4fa6e9938c"
#define RUBY_FULL_REVISION "4fa6e9938cfb9458abd876ad4219a6648bfe1c96"
#define RUBY_RELEASE_YEAR 2025
#define RUBY_RELEASE_MONTH 11
#define RUBY_RELEASE_DAY 17

hsbt@LAPLACE C:\Users\hsbt\Downloads\ruby-4.0.0-preview2>nmake up

hsbt@LAPLACE C:\Users\hsbt\Downloads\ruby-4.0.0-preview2>win32\configure.bat
Creating verconf.mk
type 'nmake' to make ruby.

hsbt@LAPLACE C:\Users\hsbt\Downloads\ruby-4.0.0-preview2>nmake up

Microsoft(R) Program Maintenance Utility Version 14.50.35717.0
Copyright (C) Microsoft Corporation.  All rights reserved.

Downloading bundled gem files...
revision.h updated
Downloading bundled gem files...
(snip)
Extracting bundled gem files...

hsbt@LAPLACE C:\Users\hsbt\Downloads\ruby-4.0.0-preview2>type revision.h
#define RUBY_RELEASE_YEAR 2025
#define RUBY_RELEASE_MONTH 11
#define RUBY_RELEASE_DAY 19

RUBY_REVISION and RUBY_FULL_REVISION is lost now. This caused the issue at release time of 4.0.0-preview2. We added the workaround at https://github.com/ruby/actions/commit/1561918fc1c929ee9ac4c2dd91af7870024ac193

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Closed

Applied in changeset git|8986115e0a2a989f2b2ea5945f02c7a13989d640.

---

[Bug #21697] Keep revision.h outside VCS

[hsbt (Hiroshi SHIBATA)]

• Status changed from Closed to Open