Bug #4225: IO.foreach should only accept string arguments

• Status: Rejected
• Assignee: -
• Target version: -
• ruby -v: ruby 1.8.7 (2010-08-16 patchlevel 302) [i686-darwin8.11.1]

[djberg96 (Daniel Berger)]

It looks like the IO.foreach method doesn't check its argument type first if no block is provided:

fh = File.new('somefile.txt')

IO.foreach(fh.fileno) # Or, IO.foreach(999999999)
=> #<Enumerable::Enumerator:0x110b0d4>

IO.foreach(fh.fileno){ |line| p line }
TypeError: can't convert Fixnum into String

I'd flip these two lines in io.c:

RETURN_ENUMERATOR(self, argc, argv);
SafeStringValue(fname);

Otherwise, what am I enumerating?

[nobu (Nobuyoshi Nakada)]

• Target version changed from Ruby 1.8.7 to Ruby 1.8.8

[shyouhei (Shyouhei Urabe)]

• Project changed from 2 to Ruby
• Category changed from core to core
• Target version deleted (Ruby 1.8.8)

I guess this one still occurs?

[djberg96 (Daniel Berger)]

Still happening as of 2.1.2.

[nobu (Nobuyoshi Nakada)]

• Description updated (diff)
• Status changed from Open to Rejected

Not only IO.foreach, an enumerator defers argument check in general.

[djberg96 (Daniel Berger)]

Why do they defer?