Bug #4422

[ext/openssl] Fix DSA public key PEM encoding

Added by Martin Bosslet about 3 years ago. Updated almost 3 years ago.

[ruby-core:35328]
Status:Closed
Priority:Normal
Assignee:Martin Bosslet
Category:ext
Target version:1.9.3
ruby -v:ruby 1.9.2p180 (2011-02-18 revision 30909) [i686-linux] Backport:

Description

=begin
Related to http://redmine.ruby-lang.org/issues/show/4421.

The difference is that DSA already uses the "right" function for DER encoding,
but the "wrong" function (PEMwritebioDSAPublicKey instead of
PEM
writebioDSA_PUBKEY) for PEM encoding.

Similar to the RSA case, fallbacks in initialize are also re-prioritized
and again this should cause no trouble because initialize recognizes all
of the formats.

Regards,
Martin
=end

fix_dsa_pub_encoding.diff Magnifier (1.05 KB) Martin Bosslet, 02/22/2011 08:25 AM

Associated revisions

Revision 31523
Added by emboss almost 3 years ago

Thu May 12 08:18:45 2011 Martin Bosslet Martin.Bosslet@googlemail.com

* ext/openssl/ossl_pkey_dsa.c: Use generic X.509 SubjectPublicKeyInfo
  format for PEM-encoding DSA public keys. 
   [Bug #4422]

Previous revision: 31520

Revision 31554
Added by emboss almost 3 years ago

Sat May 14 04:19:06 2011 Martin Bosslet Martin.Bosslet@googlemail.com

* NEWS: Describe altered behaviour for RSA and DSA public key
encoding. [Ruby 1.9 - Bug #4421, Bug #4422]
[ruby-core:35327,35328]

Previous revision: 31553

Revision 31560
Added by emboss almost 3 years ago

Sat May 14 10:32:36 2011 Martin Bosslet Martin.Bosslet@googlemail.com

* test/openssl/test_pkey_rsa.rb: Add tests that ensure new public key
encoding behavior and also ensure backward compatibility.
[Ruby 1.9 - Bug #4421, Bug #4422] [ruby-core:35327,35328]

previous revision: 31559

Revision 31562
Added by emboss almost 3 years ago

Sat May 14 12:00:54 2011 Martin Bosslet Martin.Bosslet@googlemail.com

* test/openssl/test_pkey_dsa.rb: Add basic tests and tests that 
ensure new public key PEM encoding behavior and ensure backward 
compatibility.
[Ruby 1.9 - Bug #4422] 
* test/openssl/test_pkey_rsa.rb: Remove line with 'puts'.

previous revision: 31561

History

#1 Updated by Yui NARUSE about 3 years ago

  • Status changed from Open to Assigned
  • Assignee set to Hiroshi Nakamura

=begin

=end

#2 Updated by Martin Bosslet almost 3 years ago

  • Assignee changed from Hiroshi Nakamura to Martin Bosslet

#3 Updated by Anonymous almost 3 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r31523.
Martin, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


Thu May 12 08:18:45 2011 Martin Bosslet Martin.Bosslet@googlemail.com

* ext/openssl/ossl_pkey_dsa.c: Use generic X.509 SubjectPublicKeyInfo
  format for PEM-encoding DSA public keys. 
   [Bug #4422]

Previous revision: 31520

Also available in: Atom PDF