Bug #5162

IMAP error formatting string

Added by art lussos almost 4 years ago. Updated almost 4 years ago.

[ruby-core:38819]
Status:Rejected
Priority:Normal
Assignee:Shugo Maeda
ruby -v:ruby 1.9.2p290 (2011-07-09 revision 32553) [x86_64-darwin10.8.0] Backport:

Description

In the method msg_att in the file imap.rb, the parse error is written as

parse_error("unknown attribute `%s'", token.value), I believe it should be parse_error("unknown attribute '%s'", token.value).

Single quotes on both sides of %s

History

#1 Updated by Shugo Maeda almost 4 years ago

  • Status changed from Open to Assigned
  • Assignee set to Shugo Maeda

#2 Updated by Shugo Maeda almost 4 years ago

art lussos wrote:

In the method msg_att in the file imap.rb, the parse error is written as

parse_error("unknown attribute `%s'", token.value), I believe it should be parse_error("unknown attribute '%s'", token.value).

Single quotes on both sides of %s

I don't know why the back quote is not good. Ruby uses back quotes in many other cases.

$ ruby -e 'foo'
-e:1:in <main>': undefined local variable or methodfoo' for main:Object (NameError)

#3 Updated by art lussos almost 4 years ago

Shugo Maeda wrote:

art lussos wrote:

In the method msg_att in the file imap.rb, the parse error is written as

parse_error("unknown attribute `%s'", token.value), I believe it should be parse_error("unknown attribute '%s'", token.value).

Single quotes on both sides of %s

I don't know why the back quote is not good. Ruby uses back quotes in many other cases.

$ ruby -e 'foo'
-e:1:in <main>': undefined local variable or methodfoo' for main:Object (NameError)

For consistency I believe you are correct, I just felt it would make it easier to read.

#4 Updated by Shugo Maeda almost 4 years ago

  • Status changed from Assigned to Rejected

Hello,

art lussos wrote:

I don't know why the back quote is not good. Ruby uses back quotes in many other cases.

$ ruby -e 'foo'
-e:1:in <main>': undefined local variable or methodfoo' for main:Object (NameError)

For consistency I believe you are correct, I just felt it would make it easier to read.

So I'll close this ticket. Thanks.

Also available in: Atom PDF