Bug #5162: IMAP error formatting string

• Status: Rejected
• Assignee: shugo (Shugo Maeda)
• Target version: -
• ruby -v: ruby 1.9.2p290 (2011-07-09 revision 32553) [x86_64-darwin10.8.0]

[art.lussos (art lussos)]

In the method msg_att in the file imap.rb, the parse error is written as

parse_error("unknown attribute `%s'", token.value), I believe it should be parse_error("unknown attribute '%s'", token.value).

Single quotes on both sides of %s

[shugo (Shugo Maeda)]

• Status changed from Open to Assigned
• Assignee set to shugo (Shugo Maeda)

[shugo (Shugo Maeda)]

art lussos wrote:

In the method msg_att in the file imap.rb, the parse error is written as

parse_error("unknown attribute `%s'", token.value), I believe it should be parse_error("unknown attribute '%s'", token.value).

Single quotes on both sides of %s

I don't know why the back quote is not good. Ruby uses back quotes in many other cases.

$ ruby -e 'foo'
-e:1:in <main>': undefined local variable or method foo' for main:Object (NameError)

[art.lussos (art lussos)]

Shugo Maeda wrote:

art lussos wrote:

In the method msg_att in the file imap.rb, the parse error is written as

parse_error("unknown attribute `%s'", token.value), I believe it should be parse_error("unknown attribute '%s'", token.value).

Single quotes on both sides of %s

I don't know why the back quote is not good. Ruby uses back quotes in many other cases.

$ ruby -e 'foo'
-e:1:in <main>': undefined local variable or method foo' for main:Object (NameError)

For consistency I believe you are correct, I just felt it would make it easier to read.

[shugo (Shugo Maeda)]

• Status changed from Assigned to Rejected

Hello,

art lussos wrote:

I don't know why the back quote is not good. Ruby uses back quotes in many other cases.

$ ruby -e 'foo'
-e:1:in <main>': undefined local variable or method foo' for main:Object (NameError)

For consistency I believe you are correct, I just felt it would make it easier to read.

So I'll close this ticket. Thanks.