Bug #5336

[PATCH] test_ssl_session: wait for callbacks to run in server thread

Added by Eric Wong over 2 years ago. Updated over 2 years ago.

[ruby-core:39619]
Status:Closed
Priority:Normal
Assignee:Martin Bosslet
Category:ext
Target version:1.9.3
ruby -v:ruby 1.9.3dev (2011-09-17 revision 33263) [x86_64-linux] Backport:

Description

test/openssl/testsslsession.rb: wait for callbacks to run in server thread

Closing the SSL connection on the client side does not ensure the
server side has closed and called all the needed callbacks in
the server thread. Using Thread.pass here should force the
server thread to run and call the needed callbacks.

I needed to reproduce the case like this after a few loops:

while ./ruby -I .ext/x86_64-linux/ \
    test/openssl/test_ssl_session.rb -v \
    -n test_ctx_server_session_cb
do
    :
done

The above loop appears to run indefinitely with this patch
applied.

0001-test-openssl-test_ssl_session.rb-wait-for-callbacks-.patch Magnifier (1.25 KB) Eric Wong, 09/19/2011 04:35 PM

Associated revisions

Revision 33311
Added by emboss over 2 years ago

  • test/openssl/testsslsession.rb: ensure server calls callbacks in testctxserversessioncb. Thanks to Eric Wong for the patch. [Bug #5336]

History

#1 Updated by Anonymous over 2 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r33311.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • test/openssl/testsslsession.rb: ensure server calls callbacks in testctxserversessioncb. Thanks to Eric Wong for the patch. [Bug #5336]

#2 Updated by Martin Bosslet over 2 years ago

  • Target version changed from 2.0.0 to 1.9.3

When looping I encountered the same behaviour as Eric.
With his patch the problem is now gone.

Also available in: Atom PDF