Project

General

Profile

Bug #5516

fill_standard_fds uses F_GETFD which is not defined on MinGW (broken build)

Added by luislavena (Luis Lavena) almost 8 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Normal
Target version:
ruby -v:
-
Backport:
[ruby-core:40526]

Description

Hello,

New fill_standard_fds broke build under MinGW:

compiling ../../../../ruby/ruby.c
../../../../ruby/ruby.c: In function 'fill_standard_fds':
../../../../ruby/ruby.c:1822:19: error: 'F_GETFD' undeclared (first use in this function)
../../../../ruby/ruby.c:1822:19: note: each undeclared identifier is reported only once for each function it appears in
make: *** [ruby.o] Error 1

Similar to #5470

Associated revisions

Revision a3efca16
Added by akr (Akira Tanaka) almost 8 years ago

  • ruby.c (fill_standard_fds): use fstat() instead of fcntl(F_GETFD) for MinGW. reported by Luis Lavena. [ruby-core:40526] [Bug #5516]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@33573 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 33573
Added by akr (Akira Tanaka) almost 8 years ago

  • ruby.c (fill_standard_fds): use fstat() instead of fcntl(F_GETFD) for MinGW. reported by Luis Lavena. [ruby-core:40526] [Bug #5516]

Revision 33573
Added by akr (Akira Tanaka) almost 8 years ago

  • ruby.c (fill_standard_fds): use fstat() instead of fcntl(F_GETFD) for MinGW. reported by Luis Lavena. [ruby-core:40526] [Bug #5516]

Revision 33573
Added by akr (Akira Tanaka) almost 8 years ago

  • ruby.c (fill_standard_fds): use fstat() instead of fcntl(F_GETFD) for MinGW. reported by Luis Lavena. [ruby-core:40526] [Bug #5516]

Revision 33573
Added by akr (Akira Tanaka) almost 8 years ago

  • ruby.c (fill_standard_fds): use fstat() instead of fcntl(F_GETFD) for MinGW. reported by Luis Lavena. [ruby-core:40526] [Bug #5516]

Revision 33573
Added by akr (Akira Tanaka) almost 8 years ago

  • ruby.c (fill_standard_fds): use fstat() instead of fcntl(F_GETFD) for MinGW. reported by Luis Lavena. [ruby-core:40526] [Bug #5516]

Revision 33573
Added by akr (Akira Tanaka) almost 8 years ago

  • ruby.c (fill_standard_fds): use fstat() instead of fcntl(F_GETFD) for MinGW. reported by Luis Lavena. [ruby-core:40526] [Bug #5516]

Revision 04918f81
Added by kosaki (Motohiro KOSAKI) over 7 years ago

merge revision(s) 33567,33573:

    * ruby.c (fill_standard_fds): new function to open closed standard
      file descriptors.
      (ruby_sysinit): call fill_standard_fds.

    * ruby.c (fill_standard_fds): use fstat() instead of fcntl(F_GETFD)
      for MinGW.  reported by Luis Lavena.  [ruby-core:40526] [Bug #5516]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@34452 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

History

#1

Updated by akr (Akira Tanaka) almost 8 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r33573.
Luis, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • ruby.c (fill_standard_fds): use fstat() instead of fcntl(F_GETFD) for MinGW. reported by Luis Lavena. [ruby-core:40526] [Bug #5516]

Also available in: Atom PDF