Project

General

Profile

Bug #5604

Remove extra ":" in errors created by ossl_raise

Added by drbrain (Eric Hodel) about 8 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Normal
Target version:
-
ruby -v:
-
Backport:
[ruby-core:40896]

Description

Callers of ossl_raise do not need to provide a ":" at the end of the error string because ossl_raise calls ossl_make_error which will add the ":" if necessary.

Without this patch some OpenSSL errors look like "SSL_CTX_set_cipher_list:: no cipher match (OpenSSL::SSL::SSLError)"

This patch removes the extra ":" added by callers of osl_raise so errors look like "SSL_CTX_set_cipher_list: no cipher match (OpenSSL::SSL::SSLError)".


Files

openssl.remove_colon_in_ossl_raise.patch (4.1 KB) openssl.remove_colon_in_ossl_raise.patch drbrain (Eric Hodel), 11/10/2011 08:37 AM

Associated revisions

Revision 29b0d9d9
Added by emboss almost 8 years ago

  • ext/openssl/ossl_pkey_dsa.c: remove redundant colon from error message.
  • ext/openssl/ossl_ssl.c: ditto.
  • ext/openssl/ossl_pkey_rsa: ditto. [Bug #5604] [ruby-core:40896]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@33821 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 33821
Added by emboss almost 8 years ago

  • ext/openssl/ossl_pkey_dsa.c: remove redundant colon from error message.
  • ext/openssl/ossl_ssl.c: ditto.
  • ext/openssl/ossl_pkey_rsa: ditto. [Bug #5604] [ruby-core:40896]

Revision 33821
Added by emboss almost 8 years ago

  • ext/openssl/ossl_pkey_dsa.c: remove redundant colon from error message.
  • ext/openssl/ossl_ssl.c: ditto.
  • ext/openssl/ossl_pkey_rsa: ditto. [Bug #5604] [ruby-core:40896]

Revision 33821
Added by emboss almost 8 years ago

  • ext/openssl/ossl_pkey_dsa.c: remove redundant colon from error message.
  • ext/openssl/ossl_ssl.c: ditto.
  • ext/openssl/ossl_pkey_rsa: ditto. [Bug #5604] [ruby-core:40896]

Revision 33821
Added by emboss almost 8 years ago

  • ext/openssl/ossl_pkey_dsa.c: remove redundant colon from error message.
  • ext/openssl/ossl_ssl.c: ditto.
  • ext/openssl/ossl_pkey_rsa: ditto. [Bug #5604] [ruby-core:40896]

Revision 33821
Added by emboss almost 8 years ago

  • ext/openssl/ossl_pkey_dsa.c: remove redundant colon from error message.
  • ext/openssl/ossl_ssl.c: ditto.
  • ext/openssl/ossl_pkey_rsa: ditto. [Bug #5604] [ruby-core:40896]

Revision 33821
Added by emboss almost 8 years ago

  • ext/openssl/ossl_pkey_dsa.c: remove redundant colon from error message.
  • ext/openssl/ossl_ssl.c: ditto.
  • ext/openssl/ossl_pkey_rsa: ditto. [Bug #5604] [ruby-core:40896]

History

#1

Updated by Anonymous almost 8 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r33821.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • ext/openssl/ossl_pkey_dsa.c: remove redundant colon from error message.
  • ext/openssl/ossl_ssl.c: ditto.
  • ext/openssl/ossl_pkey_rsa: ditto. [Bug #5604] [ruby-core:40896]

Also available in: Atom PDF